Use better test for UnsupportedClassVersionError. #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test worked correctly with the Oracle JVM but failed with other JVMs. This new test should work correctly on all JVMs.
Contributor
Author
|
The Travis build failed in just one of the 9 cases from the test matrix, due to an obscure problem with npm install: "npm ERR! Error: Attempt to unlock async@~0.1.22, which hasn't been locked." I bet this is a flakey intermittent problem with either npm or the travis environment. If we triggered another build it would almost certainly pass. |
Owner
|
@jimlloyd Agreed |
joeferner
added a commit
that referenced
this pull request
Nov 18, 2014
…ted-java-version Use better test for UnsupportedClassVersionError.
Contributor
Author
|
Thanks Joe. Please bump to v0.4.4 and publish to npm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test worked correctly with the Oracle JVM but
failed with other JVMs. This new test should work correctly
on all JVMs.
Should fix issue #172.