Move 'addMove' stateful function + add extra conditional to promotion check #563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachimbulow
commented
Sep 21, 2025
src/chess.ts
Outdated
| ) { | ||
| const r = rank(to) | ||
|
|
||
| if (piece === PAWN && ((color === BLACK && r === RANK_1) || (color === WHITE && r === RANK_8))) { |
Author
There was a problem hiding this comment.
We now check color + rank as opposed to just checking ranks
Collaborator
|
The changes / tests are unnecessary, as a white pawn can never move to the first rank, and a black pawn can never to move to the eighth rank. |
Author
|
Right - I am looking to extend the system to allow for more rules - which is what led me to that change. I have edited the description and removed the redundant check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved stateful function into chess class
Having state manipulating functionality exported and separate from the chess class seems like it breaks the general structure of having state-less util-like functions exported outside of the
chessclass.The function is not part of the public api - so should be a minor change