Add vars for tag.is-delete :hover/:focus/:active background color#3703
Open
kikuomax wants to merge 1 commit into
Open
Add vars for tag.is-delete :hover/:focus/:active background color#3703kikuomax wants to merge 1 commit into
kikuomax wants to merge 1 commit into
Conversation
- Introduces the following variables for tag:
- `$tag-delete-background-color-focus`: background color for `tag`s
with `is-delete` modifier when :hover or :focus
- `$tag-delete-background-color-active`: background color for `tag`s
with `is-delete` modifier when :active
Introduction of the above variables will break nothing because their
default bindings are the exact copies of those previously specified to
`background-color` for :hover/:focus and :active respectively.
This change will allow people to bind `$background` to CSS variables;
e.g., jgthms#3694
kikuomax
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improvement that will allow people to bind
$backgroundto CSS variables.Proposed solution
Not a direct solution to but will help:
Tradeoffs
No tradeoffs.
Testing Done
masterbranch.sassor documentation filesAdditional check: No diffs in output
css/bulma.cssfiles before and after this change.Changelog updated?
No.