Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for label selectors to the Kubernetes dynamic data gatherer, allowing users to filter resources based on their labels in addition to existing field selector functionality. This helps reduce unnecessary data collection by focusing on important resources.
Changes:
- Added
LabelSelectorsconfiguration field toConfigDynamicstruct - Implemented label selector validation in the
validate()function - Integrated label selector filtering in both dynamic and native Kubernetes informers
- Added comprehensive test coverage for label selector validation and functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/datagatherer/k8sdynamic/dynamic.go | Added label selector configuration field, validation logic, and integration with Kubernetes informers |
| pkg/datagatherer/k8sdynamic/dynamic_test.go | Added tests for label selector validation, unmarshaling, and integration with data gatherers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply label selectors to any Kubernetes resource type, such as Pods, Deployments, Secrets, or ConfigMaps. This helps focus on important resources and exclude non-essential ones, reducing unnecessary data collection.