Discovery of ConfigMaps and Label Selectors#761
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands Kubernetes discovery to include ConfigMaps and adds support for label selectors (in addition to existing field selectors) for dynamic resource listing.
Changes:
- Added
label-selectorssupport tok8s-dynamicdata gatherers (validation + propagation into informer list options). - Extended CyberArk snapshot conversion to include
ark/configmapsreadings and addedConfigMapsto the uploaded snapshot structure. - Updated the disco-agent Helm chart to include a ConfigMaps gatherer with a default label selector.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/datagatherer/k8sdynamic/dynamic.go | Adds LabelSelectors config, validates/parses it, and applies it to informer list options. |
| pkg/datagatherer/k8sdynamic/dynamic_test.go | Adds validation tests for label/field selectors (and combined cases). |
| pkg/client/client_cyberark.go | Adds default extractor mapping for ark/configmaps into Snapshot.ConfigMaps. |
| pkg/client/client_cyberark_test.go | Updates the default gatherer name list to include ark/configmaps. |
| pkg/client/client_cyberark_convertdatareadings_test.go | Adds tests covering ConfigMaps conversion and multi-resource conversions. |
| internal/cyberark/dataupload/dataupload.go | Extends Snapshot with ConfigMaps field for upload payload. |
| deploy/charts/disco-agent/templates/configmap.yaml | Adds ark/configmaps gatherer entry with a default label-selectors filter. |
| deploy/charts/disco-agent/tests/snapshot/configmap_test.yaml.snap | Updates chart snapshot expectations to include the new ConfigMaps gatherer config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@achuchev could you create a separate PR for the label selectors first? |
Contributor
Author
Contributor
Author
Contributor
|
This PR was replaced by 2 smaller PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigMaps Discovery & Label Selectors
Business Value
These enhancements provide users with greater control and flexibility over Kubernetes resource discovery:
Changes
Feature 1: ConfigMap Discovery
Added ConfigMap resource type to the dynamic data gatherer:
configmapsinto the informer-based collection pipelineFeature 2: Label Selectors
Implemented label selectors for all resource types:
conjur.org/name=conjur-connect-configmapis set for ConfigMap resources.How to test locally
go run . agent --one-shot --machine-hub -v 6 --agent-config-file ./examples/machinehub.yaml