Skip to content

fix(nix): use nixos-unstable#4948

Merged
stefanhaller merged 1 commit into
jesseduffield:masterfrom
doprz:fix/nixpkgs-unstable
Oct 9, 2025
Merged

fix(nix): use nixos-unstable#4948
stefanhaller merged 1 commit into
jesseduffield:masterfrom
doprz:fix/nixpkgs-unstable

Conversation

@doprz
Copy link
Copy Markdown
Contributor

@doprz doprz commented Oct 8, 2025

Fixed #4947

PR Description

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@doprz doprz mentioned this pull request Oct 8, 2025
Merged
7 tasks
@stefanhaller
Copy link
Copy Markdown
Collaborator

stefanhaller commented Oct 8, 2025

I don't know anything about nix, so I'm probably not qualified to ask, but doesn't this "fix" simply rely on unstable having a new enough go version, whereas 25.05 doesn't? If so, this doesn't seem right to me. The flake should be able to build lazygit no matter what go version the underlying nixpkgs comes with, and I thought this goVersion overlay would achieve that.

@Eveeifyeve Any input on this?

@doprz
Copy link
Copy Markdown
Contributor Author

doprz commented Oct 8, 2025

Yes that is correct. Similar to Linux distributions, each stable version has a set of packages (and versions allowed). It seems that Go 1.25 is not yet packaged in the 25.05 release so by moving to the "unstable" (rolling-release) it's able to use the newer Go version.

Eveeifyeve
Eveeifyeve approved these changes Oct 9, 2025
View reviewed changes
Copy link
Copy Markdown

@Eveeifyeve Eveeifyeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This indeed fixes the issue, because 25.05 doesn't have a newer enough go version packaged than this required.

Good catch by the way on the channels, I would have blocked the pr from merging if I checked but I didn't check for the channels.

@stefanhaller stefanhaller added the ignore-for-release This will exclude the PR from release notes label Oct 9, 2025
@stefanhaller
Copy link
Copy Markdown
Collaborator

stefanhaller commented Oct 9, 2025

Ok; thanks, both.

@stefanhaller stefanhaller merged commit 1f002af into jesseduffield:master Oct 9, 2025
13 of 14 checks passed
@doprz doprz deleted the fix/nixpkgs-unstable branch October 9, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Eveeifyeve Eveeifyeve Eveeifyeve approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ignore-for-release This will exclude the PR from release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nix flake broken by Go 1.25

3 participants

@doprz @stefanhaller @Eveeifyeve