This repository was archived by the owner on Jun 2, 2025. It is now read-only.
optimize calculation of next power of 2 >= of given number#1303
Merged
davidtgoldblatt merged 1 commit intojemalloc:devfrom Aug 16, 2018
Merged
optimize calculation of next power of 2 >= of given number#1303davidtgoldblatt merged 1 commit intojemalloc:devfrom
davidtgoldblatt merged 1 commit intojemalloc:devfrom
Conversation
Closed
Contributor
|
LGTM. @davidtgoldblatt this should be good to go. |
Contributor
|
Nit: could you clean up the commit message a little? E.g. "Bit_util: Use intrinsics for pow2_ceil, where available." |
rkmisra
force-pushed
the
optimize_pow2_674_clean
branch
from
84d2ec0 to
4b5c62c
Compare
Contributor
Author
|
Is current commit message good enough or should I add more details? |
Contributor
|
Looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This overrides #1118 and is being used to push changes required to implement #674
This is being done for clean commit and merge.