Fix flaky test that depends on current minute #9889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test fix.
Summary
Fix flaky test that depends on current minute number.
Context
Sometimes, the Cucumber tests suite fails on GitHub Actions at the scenario
Use site.time variable. For example, see this run: https://github.com/jekyll/jekyll/actions/runs/17277324576/job/49037269833#step:5:473I've tracked down the problem and can reproduce it locally executing:
In one or two minutes at most, the test eventually fails.
It's flaky because it depends on the concordance of the current minute before and after the build. The build takes, in my local environment, from ~150 ms to 1s, so the medium probablity of failure is ~1%.
The fix proposes the usage of a time range with 5 seconds of tolerance. The unused helper functions have been removed.