fix: glassy dark theme#1924
Open
Nicolach5 wants to merge 23 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
The first fix removed the glassy effect for the player bar, so i readded that and instead calculated the height of the right sidebar separately |
Owner
pyxfluff
suggested changes
Apr 8, 2026
Author
|
I'll try to fix it tomorrow as I really like the theme. which is how the content goes underneath the playerbar, but it also affects the right sidebar, so I was fixing my mistake there |
I rewrote it completely to work with all the possible layouts, plus some fixes for the album page and the home page. It could probably be done way better with less code, but from my testing both in linux desktop and web, I probably covered all cases where elements could go underneath the playerbar, plus some other fixes i figured while experimenting
Author
|
As mentioned in #1887, it seems there were other issues causing the publish task to fail because of an OOM error in the macos build. I tested in my fork and this happened even without my changes, inconsistently failing to build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes both the issue with the lyrics module (#1917) and the queue (#1895)
After fix:
