Optimized speed of initializing reserved words list.

Gobie · Gobie · commit 62b4cc0fa103 · 2013-11-26T12:44:02.000+01:00
diff --git a/lib/SqlFormatter.php b/lib/SqlFormatter.php
@@ -178,8 +178,10 @@ protected static function init()
     {
         if (self::$init) return;
 
-        // Sort reserved word list from longest word to shortest
-        usort(self::$reserved, array('SqlFormatter', 'sortLength'));
+        // Sort reserved word list from longest word to shortest, 3x faster than usort
+        $reservedMap = array_combine(self::$reserved, array_map('strlen', self::$reserved));
+        arsort($reservedMap);
+        self::$reserved = array_keys($reservedMap);
 
         // Set up regular expressions
         self::$regex_boundaries = '('.implode('|',array_map(array('SqlFormatter', 'quote_regex'),self::$boundaries)).')';
@@ -1030,19 +1032,6 @@ protected static function highlightVariable($value)
         }
     }
 
-    /**
-     * Helper function for sorting the list of reserved words by length
-     *
-     * @param String $a The first string
-     * @param String $b The second string
-     *
-     * @return int The comparison of the string lengths
-     */
-    private static function sortLength($a, $b)
-    {
-        return strlen($b) - strlen($a);
-    }
-
     /**
      * Helper function for building regular expressions for reserved words and boundary characters
      *
