GitHub: Remove table-related roles from release asset links#28
GitHub: Remove table-related roles from release asset links#28jscholes wants to merge 1 commit intojcsteh:masterfrom
Conversation
|
@jcsteh I may've been a bit hasty with this one. It occurred to me that the script's own transformation of issues lists into tables may be causing this problem, rather than it being a GitHub thing. I'll look at it again when I'm back at my computer. |
|
@jcsteh Confirmed. The I think having release assets actually be in a table would be useful, but looking into that will be more than the quick fix I was expecting. Would you prefer for this PR to be closed in favour of a new one, if/when I have the time to look at it again? |
|
Oof. This is nastier still because the links end up getting a role of cell. That said, I think this fix could be fragile given that we're effectively undoing something we did, so I do think it needs another solution. Thanks for the contribution though. |
It would be ideal if this were a table, but we're not currently matching the table correctly and we're breaking the links by giving them a role of cell. For now, just don't mess with it until we have a better solution. Re #28.
2 participants
Example page: https://github.com/aome510/spotify-player/releases (under the "v0.18.2" and then "Assets".