add new title for asus router firmware#27
Conversation
derekriemer
commented
Mar 10, 2024
derekriemer
commented
- add new fixes for asus router firmware.
- update skeleton with function to update a live region temporarily.
* fixes up nav menus. * makes some toggles labeled. * makes tutor help offered in settings pannels accessible.
|
Oh, please also rename this to AsusRouterA11yFixes.user.js. |
Co-authored-by: James Teh <jamie@jantrid.net>
jcsteh
left a comment
jcsteh
left a comment
There was a problem hiding this comment.
This all looks great barring some nits... but uh, where did the actual Asus Router script go? It seems to have been removed.
framework/axSGreaseSkeleton.js
Outdated
| * @param {string} id the name of the new live region. This is an html id. | ||
| * @return {!Promise<HTMLElement>} a div that contains the live region. This can typically be ignored, this exxists to aid in chaining creation of non-existant regions. | ||
| */ | ||
|
|
| // annimation frames, so delay 134 ms to be safe. | ||
| setTimeout(() => { | ||
| resolve(region); | ||
| }, 134); |
There was a problem hiding this comment.
Just out of curiosity, why 134 (as opposed to 130 or similar)? Is 134 significant somehow?
There was a problem hiding this comment.
1000/30 (frames per second) is 3.333... * 3 is 333 ...4 when rounded. Ballpark math tbh.
framework/axSGreaseSkeleton.js
Outdated
| }); | ||
|
|
||
| /** add your specific initialization here, so that if you ever update the framework from new skeleton your inits are not overridden. */ | ||
| function userInit(){} |
There was a problem hiding this comment.
This is a great idea, but I'd move it down below the /*** Define the actual tweaks. ***/ comment so it's easier to paste in the new skeleton without breaking your stuff.
Co-authored-by: James Teh <jamie@jantrid.net>
Co-authored-by: James Teh <jamie@jantrid.net>
|
I can't figure out how to reply to your comment. uh ... so yeah what happened is ... I am used to using a heavily modified murcurial at work. I renamed the file and my ide at work is smart enough to rename (git mv basically) the file, so when I renamed the file in my editor, it got untracked and the new one never got re-tracked. Silly error really. This should be better. |
|
This is ready for more review. I don't understand how this review thing works on github. How do I send it back to you for another go round???? |
framework/axSGreaseSkeleton.js
Outdated
| return updatePromise; | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Um... I think this comments out a huge block of code below?
There was a problem hiding this comment.
It's just the dangling start of a sad comment that was 99% deleted. I've gone back in and eliminated the rest of it. :-)
Co-authored-by: James Teh <jamie@jantrid.net>
|
I'm done again. |
| const DYNAMIC_TWEAKS = [ | ||
| ]; | ||
|
|
||
| /** add your specific initialization here, so that if you ever update the framework from new skeleton your inits are not overridden. */ |
There was a problem hiding this comment.
| /** add your specific initialization here, so that if you ever update the framework from new skeleton your inits are not overridden. */ | |
| /** Add your specific initialization here, so that if you ever update the framework from new skeleton your inits are not overridden. */ |
2 participants
