Skip to content

Slack: Remove extra a11y attributes from close_flexpane button #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcsteh merged 1 commit into from
Apr 13, 2017
Merged

Slack: Remove extra a11y attributes from close_flexpane button #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions SlackA11yFixes.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ function initial() {
// Same for the unread messages status, which appears below in DOM order but earlier visually.
if (elem = document.querySelector("#messages_container"))
elem.setAttribute("aria-owns", "messages_unread_status threads_view_banner monkey_scroll_wrapper_for_msgs_scroller_div monkey_scroll_wrapper_for_threads_msgs_scroller_div");
// Make close link for about channel pane accessible.
for (elem of document.querySelectorAll(".close_flexpane")) {
elem.setAttribute("role", "button");
// The content is a private use Unicode character. Use the title as the name.
elem.setAttribute("aria-label", elem.getAttribute("title"));
}
}

// Make the starred status accessible.
Expand Down
1 change: 0 additions & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ It does the following:
- Makes options for each message (Start a thread, Share message, etc.) accessible.
To access these, move the mouse to the text of a message.
They then appear above the author's name as buttons.
- Makes the close link for the about channel pane accessible.
- Makes day separators in the message history and the about channel pane heading accessible as headings.
- Reports incoming messages automatically (using a live region).
- Hides an editable area which isn't shown visually.
Expand Down