Slack: Remove extra a11y attributes from close_flexpane button#11
Merged
jcsteh merged 1 commit intojcsteh:masterfrom Apr 13, 2017
Merged
Slack: Remove extra a11y attributes from close_flexpane button#11jcsteh merged 1 commit intojcsteh:masterfrom
close_flexpane button#11jcsteh merged 1 commit intojcsteh:masterfrom
Conversation
jwyung
force-pushed
the
slack-remove-close-flexpane
branch
from
46428ca to
4a3a937
Compare
Based on the `close_flexpane` button markup on Slack now, we have: `<button class="btn_basic close_flexpane" aria-label="Close Right Sidebar" title="Close Right Sidebar" type="button">` - Since this element is a `<button>`, the `role` attribute is no longer necessary - Since this element has an `aria-label` attribute, we no longer need to add one - Update "Slack Accessibility Fixes" in README to reflect the above changes
jwyung
force-pushed
the
slack-remove-close-flexpane
branch
from
4a3a937 to
357360d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the
close_flexpanebutton markup on Slack now, we have:<button class="btn_basic close_flexpane" aria-label="Close Right Sidebar" title="Close Right Sidebar" type="button"><button>, theroleattribute is no longer necessaryaria-labelattribute, we no longer need to add one