Skip to content

chore(deps): update github artifact actions (major) #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbdevprimary wants to merge 1 commit into from
Closed

chore(deps): update github artifact actions (major) #9

jbdevprimary wants to merge 1 commit into from
+13 −13

Conversation

@jbdevprimary
Copy link
Contributor

@jbdevprimary jbdevprimary commented Dec 16, 2025 •
edited by cursor bot
Loading

Migrated from jbdevprimary/ai_game_dev#13

This PR contains the following updates:

Package Type Update Change
actions/download-artifact action major v3 -> v6
actions/upload-artifact action major v3 -> v5

Release Notes

actions/download-artifact (actions/download-artifact)

v6

Compare Source

v5

Compare Source

v4

Compare Source

actions/upload-artifact (actions/upload-artifact)

v5

Compare Source

v4

Compare Source

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Note

Upgrade GitHub Actions artifact steps to actions/upload-artifact@v5 and actions/download-artifact@v6 across CI and release workflows.

  • CI/CD Workflows:
    • .github/workflows/pre-commit.yml: Use actions/upload-artifact@v5 for pre-commit failure artifacts.
    • .github/workflows/release.yml:
      • Replace upload steps with actions/upload-artifact@v5 in build-python, build-rust, build-godot.
      • Use actions/download-artifact@v6 in create-release and publish-pypi.
    • .github/workflows/static-analysis.yml:
      • Use actions/upload-artifact@v5 for analysis, coverage, quality, and performance artifacts.
      • Use actions/download-artifact@v6 in quality-gates.

Written by Cursor Bugbot for commit 045c0f4. This will update automatically on new commits. Configure here.

@renovate renovate bot force-pushed the renovate/major-github-artifact-actions branch from 045c0f4 to b6eb327 Compare December 19, 2025 15:14
@claude
Copy link

claude bot commented Dec 19, 2025

Code Review Summary

I've reviewed this PR which upgrades GitHub Actions artifact actions. Here are my findings:

Critical Issue - Version Mismatch

Problem: The PR incorrectly upgrades actions/download-artifact to v7 in three locations, but v7 does not exist yet. The latest available version is v6.

Affected Lines:

  • .github/workflows/release.yml:204 - actions/download-artifact@v7
  • .github/workflows/release.yml:265 - actions/download-artifact@v7
  • .github/workflows/static-analysis.yml:129 - actions/download-artifact@v7

Required Fix: Change all @v7 references to @v6

Correct Changes

The following upgrades are correct:

  • actions/upload-artifact@v3 to @v6 (5 instances)
  • actions/download-artifact@v3 should be @v6 (currently incorrectly set to v7)

Breaking Changes to Consider

When upgrading from v3 to v6 for these actions, there are important breaking changes:

  1. Artifact Isolation: In v4+, artifacts are isolated by default between jobs in the same workflow run. This is beneficial for this codebase.

  2. Merge Behavior: The merge-multiple option exists in v4+ but defaults to false. Since your workflows download artifacts with specific names, this should work correctly.

  3. Path Handling: v4+ has improved path handling and glob support which should work with existing configurations.

Workflow-Specific Analysis

pre-commit.yml: Safe - Only uploads on failure
release.yml: Needs version fix - Downloads artifacts in create-release and publish-pypi jobs
static-analysis.yml: Needs version fix - Downloads multiple artifacts in quality-gates job

Testing Recommendations

  1. Test the release workflow end-to-end in a non-production branch
  2. Verify artifact upload/download works correctly between jobs
  3. Confirm that artifact names and paths are preserved correctly
  4. Validate that the path: release-artifacts directory structure is maintained

Impact Assessment

Risk Level: Medium (due to version error)
Breaking Changes: Yes (artifact isolation, but beneficial)
Rollback Complexity: Low (can revert to v3 easily)

Recommendations

  1. MUST FIX: Correct v7 to v6 for download-artifact
  2. Consider pinning to exact commit SHAs for production stability
  3. Test in a feature branch before merging
  4. Monitor the first production run closely

Would you like me to create the fix for the version mismatch?

claude[bot]
claude bot requested changes Dec 19, 2025
View reviewed changes
Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a critical version error that needs to be fixed before merging. The actions/download-artifact action should be upgraded to v6, not v7 (which doesn't exist yet).

@renovate renovate bot force-pushed the renovate/major-github-artifact-actions branch from b6eb327 to 5e4f58f Compare December 23, 2025 09:38
@renovate renovate bot closed this Dec 23, 2025
@renovate renovate bot deleted the renovate/major-github-artifact-actions branch December 23, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbdevprimary