Bug 11126 - Give ability to define tags post storage addition

prachi · prachi · commit f56c3d7bc5d4 · 2011-11-23T14:21:34.000-08:00
Changes:
- Enabled updating storage tags
- All existing tags are wiped out and new ones provided are stored.
- Note that, if tags are updated on the storage, no changes are done to the deployment of already running VMs that were deployed prior to tag addition.
- Also added some validation to host tags update API.
diff --git a/api/src/com/cloud/api/commands/UpdateStoragePoolCmd.java b/api/src/com/cloud/api/commands/UpdateStoragePoolCmd.java
@@ -18,6 +18,8 @@
 
 package com.cloud.api.commands;
 
+import java.util.List;
+
 import org.apache.log4j.Logger;
 
 import com.cloud.api.ApiConstants;
@@ -44,8 +46,9 @@ public class UpdateStoragePoolCmd extends BaseCmd {
     @Parameter(name=ApiConstants.ID, type=CommandType.LONG, required=true, description="the Id of the storage pool")
     private Long id;
 
-    @Parameter(name=ApiConstants.TAGS, type=CommandType.STRING, description="the tags for the storage pool")
-    private String tags;
+    @Parameter(name=ApiConstants.TAGS, type=CommandType.LIST, collectionType=CommandType.STRING, description="comma-separated list of tags for the storage pool")
+    private List<String> tags;
+    
 
     /////////////////////////////////////////////////////
     /////////////////// Accessors ///////////////////////
@@ -55,7 +58,7 @@ public Long getId() {
         return id;
     }
 
-    public String getTags() {
+    public List<String> getTags() {
         return tags;
     }
 
diff --git a/client/tomcatconf/commands.properties.in b/client/tomcatconf/commands.properties.in
@@ -213,7 +213,7 @@ listAsyncJobs=com.cloud.api.commands.ListAsyncJobsCmd;15
 #### storage pools commands
 listStoragePools=com.cloud.api.commands.ListStoragePoolsCmd;3
 createStoragePool=com.cloud.api.commands.CreateStoragePoolCmd;1
-#### updateStoragePool=com.cloud.api.commands.UpdateStoragePoolCmd;1
+updateStoragePool=com.cloud.api.commands.UpdateStoragePoolCmd;1
 deleteStoragePool=com.cloud.api.commands.DeletePoolCmd;1
 listClusters=com.cloud.api.commands.ListClustersCmd;3
 enableStorageMaintenance=com.cloud.api.commands.PreparePrimaryStorageForMaintenanceCmd;1
diff --git a/server/src/com/cloud/host/dao/HostTagsDaoImpl.java b/server/src/com/cloud/host/dao/HostTagsDaoImpl.java
@@ -63,8 +63,11 @@ public void persist(long hostId, List<String> hostTags) {
         expunge(sc);
         
         for (String tag : hostTags) {
-        	HostTagVO vo = new HostTagVO(hostId, tag);
-            persist(vo);
+            tag.trim();
+            if(tag.length() > 0) {
+                HostTagVO vo = new HostTagVO(hostId, tag);
+                persist(vo);
+            }
         }
         txn.commit();
     }
diff --git a/server/src/com/cloud/storage/StorageManagerImpl.java b/server/src/com/cloud/storage/StorageManagerImpl.java
@@ -1341,17 +1341,16 @@ public StoragePoolVO createPool(CreateStoragePoolCmd cmd) throws ResourceInUseEx
     public StoragePoolVO updateStoragePool(UpdateStoragePoolCmd cmd) throws IllegalArgumentException {
         // Input validation
         Long id = cmd.getId();
-        String tags = cmd.getTags();
+        List<String> tags = cmd.getTags();
 
         StoragePoolVO pool = _storagePoolDao.findById(id);
         if (pool == null) {
             throw new IllegalArgumentException("Unable to find storage pool with ID: " + id);
         }
 
         if (tags != null) {
-            Map<String, String> details = _storagePoolDao.getDetails(id);
-            String[] tagsList = tags.split(",");
-            for (String tag : tagsList) {
+            Map<String, String> details = new HashMap<String, String>();
+            for (String tag : tags) {
                 tag = tag.trim();
                 if (tag.length() > 0 && !details.containsKey(tag)) {
                     details.put(tag, "true");

Original file line number	Diff line number	Diff line change
`@@ -63,8 +63,11 @@ public void persist(long hostId, List<String> hostTags) {`
`63`	`63`	`expunge(sc);`
`64`	`64`
`65`	`65`	`for (String tag : hostTags) {`
`66`		`- HostTagVO vo = new HostTagVO(hostId, tag);`
`67`		`- persist(vo);`
	`66`	`+ tag.trim();`
	`67`	`+ if(tag.length() > 0) {`
	`68`	`+ HostTagVO vo = new HostTagVO(hostId, tag);`
	`69`	`+ persist(vo);`
	`70`	`+ }`
`68`	`71`	`}`
`69`	`72`	`txn.commit();`
`70`	`73`	`}`