Skip to content

Commit b2656b5

Browse files
author
Jessica Wang
committed
CS-16573: cloudstack UI - global settings page, Hypervisor Capabilities page - encode data passed to API call.
1 parent ae79a1e commit b2656b5

1 file changed

Lines changed: 19 additions & 28 deletions

File tree

ui/scripts/globalSettings.js

Lines changed: 19 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,14 @@
3030
actions: {
3131
edit: {
3232
label: 'label.change.value',
33-
action: function(args) {
34-
var name = args.data.jsonObj.name;
35-
var value = args.data.value;
36-
33+
action: function(args) {
34+
var data = {
35+
name: args.data.jsonObj.name,
36+
value: args.data.value
37+
};
3738
$.ajax({
38-
url: createURL(
39-
'updateConfiguration&name=' + name + '&value=' + value
40-
),
41-
dataType: 'json',
42-
async: true,
39+
url: createURL('updateConfiguration'),
40+
data: data,
4341
success: function(json) {
4442
var item = json.updateconfigurationresponse.configuration;
4543
if(item.category == "Usage")
@@ -95,22 +93,12 @@
9593
maxguestslimit: { label: 'label.max.guest.limit' }
9694
},
9795
dataProvider: function(args) {
98-
var array1 = [];
99-
if(args.filterBy != null) {
100-
if(args.filterBy.search != null && args.filterBy.search.by != null && args.filterBy.search.value != null) {
101-
switch(args.filterBy.search.by) {
102-
case "name":
103-
if(args.filterBy.search.value.length > 0)
104-
array1.push("&keyword=" + args.filterBy.search.value);
105-
break;
106-
}
107-
}
108-
}
109-
96+
var data = {};
97+
listViewDataProvider(args, data);
98+
11099
$.ajax({
111-
url: createURL("listHypervisorCapabilities&page=" + args.page + "&pagesize=" + pageSize + array1.join("")),
112-
dataType: "json",
113-
async: true,
100+
url: createURL('listHypervisorCapabilities'),
101+
data: data,
114102
success: function(json) {
115103
var items = json.listhypervisorcapabilitiesresponse.hypervisorCapabilities;
116104
args.response.success({data:items});
@@ -127,11 +115,14 @@
127115
edit: {
128116
label: 'label.edit',
129117
action: function(args) {
130-
var array1 = [];
131-
array1.push("&maxguestslimit=" + todb(args.data.maxguestslimit));
118+
var data = {
119+
id: args.context.hypervisorCapabilities[0].id,
120+
maxguestslimit: args.data.maxguestslimit
121+
};
122+
132123
$.ajax({
133-
url: createURL("updateHypervisorCapabilities&id=" + args.context.hypervisorCapabilities[0].id + array1.join("")),
134-
dataType: "json",
124+
url: createURL('updateHypervisorCapabilities'),
125+
data: data,
135126
success: function(json) {
136127
var item = json.updatehypervisorcapabilitiesresponse['null'];
137128
args.response.success({data: item});

0 commit comments

Comments
 (0)