CLOUDSTACK-3994: fix for Wrong error notification is generated when Primary storage is added with wrong path

anshulgangwar · Sateesh Chodapuneedi · commit 93172df5569c · 2013-10-17T13:21:58.000+05:30
Signed-off-by: Sateesh Chodapuneedi &lt;sateesh@apache.org&gt;
diff --git a/plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java b/plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
@@ -472,6 +472,8 @@ public boolean deleteDataStore(DataStore store) {
         HypervisorType hType = null;
         if(hostPoolRecords.size() > 0 ){
             hType = getHypervisorType(hostPoolRecords.get(0).getHostId());
+        } else {
+            return false;
         }
 
         // Remove the SR associated with the Xenserver

Original file line number	Diff line number	Diff line change
`@@ -472,6 +472,8 @@ public boolean deleteDataStore(DataStore store) {`
`472`	`472`	`HypervisorType hType = null;`
`473`	`473`	`if(hostPoolRecords.size() > 0 ){`
`474`	`474`	`hType = getHypervisorType(hostPoolRecords.get(0).getHostId());`
	`475`	`+ } else {`
	`476`	`+ return false;`
`475`	`477`	`}`
`476`	`478`
`477`	`479`	`// Remove the SR associated with the Xenserver`