AsyncJob reports 'Successful' even if RevertToVMSnapshot operation fails.

sanjaytripathi · sanjaytripathi · commit 92a9ee097dfd · 2015-06-19T15:48:21.000+05:30
This closes apache#484
diff --git a/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java b/server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java
@@ -709,7 +709,7 @@ private UserVm orchestrateRevertToVMSnapshot(Long vmSnapshotId) throws Insuffici
             return userVm;
         } catch (Exception e) {
             s_logger.debug("Failed to revert vmsnapshot: " + vmSnapshotId, e);
-            return null;
+            throw new CloudRuntimeException(e.getMessage());
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,7 @@ private UserVm orchestrateRevertToVMSnapshot(Long vmSnapshotId) throws Insuffici`
`709`	`709`	`return userVm;`
`710`	`710`	`} catch (Exception e) {`
`711`	`711`	`s_logger.debug("Failed to revert vmsnapshot: " + vmSnapshotId, e);`
`712`		`- return null;`
	`712`	`+ throw new CloudRuntimeException(e.getMessage());`
`713`	`713`	`}`
`714`	`714`	`}`
`715`	`715`