Vmware incremental check-in

Kelven Yang · Kelven Yang · commit 7bcff5acf326 · 2010-08-20T18:50:33.000-07:00
diff --git a/api/src/com/cloud/hypervisor/Hypervisor.java b/api/src/com/cloud/hypervisor/Hypervisor.java
@@ -23,7 +23,8 @@ public static enum Type {
     	None, //for storage hosts
     	Xen,
     	XenServer,
-    	KVM;
+    	KVM,
+    	VMware;
     }
 
 }
diff --git a/build/build-cloud.xml b/build/build-cloud.xml
@@ -264,6 +264,7 @@
 		<include name="httpcore-4.0.jar" />
 		<include name="commons-httpclient-3.1.jar" />
 		<include name="commons-codec-1.4.jar" />
+		<include name="commons-discovery.jar" />
 		<include name="email.jar" />
 		<include name="xmlrpc-client-3.1.3.jar" />
 		<include name="xmlrpc-common-3.1.3.jar" />
diff --git a/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java b/core/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java
@@ -4114,6 +4114,7 @@ protected void fillHostInfo(StartupRoutingCommand cmd) {
                     break;
                 }
             }
+            
             // assume the memory Virtualization overhead is 1/64
             ram = (ram - dom0Ram) * 63/64;
             cmd.setMemory(ram);
diff --git a/core/test/com/cloud/vmware/TestVMWare.java b/core/test/com/cloud/vmware/TestVMWare.java
@@ -19,6 +19,7 @@
 import com.vmware.vim25.VirtualDeviceConfigSpecOperation;
 import com.vmware.vim25.VirtualEthernetCard;
 import com.vmware.vim25.VirtualEthernetCardNetworkBackingInfo;
+import com.vmware.vim25.VirtualNicManagerNetConfig;
 import com.vmware.vim25.VirtualPCNet32;
 import com.vmware.vim25.VirtualDeviceConfigSpec;
 import com.vmware.vim25.VirtualMachineCloneSpec;
@@ -784,6 +785,14 @@ private void createDatacenter() throws Exception {
 			"cloud.dc.test");
 	}
 	
+	private void getPropertyWithPath() throws Exception {
+		ManagedObjectReference morHost = new ManagedObjectReference();
+		morHost.setType("HostSystem");
+		morHost.set_value("host-161");
+		
+		VirtualNicManagerNetConfig[] netConfigs = (VirtualNicManagerNetConfig[])cb.getServiceUtil3().getDynamicProperty(morHost, "config.virtualNicManagerInfo.netConfig");
+	}
+	
 	public static void main(String[] args) throws Exception {
 		setupLog4j();
 		TestVMWare client = new TestVMWare();
@@ -809,7 +818,9 @@ public static void main(String[] args) throws Exception {
 			// client.addNic();
 			// client.addNicToNetwork();
 
-			client.createDatacenter();
+			// client.createDatacenter();
+			client.getPropertyWithPath();
+		
 			cb.disConnect();
 		} catch (Exception e) {
 			e.printStackTrace();
diff --git a/server/src/com/cloud/agent/manager/AgentManagerImpl.java b/server/src/com/cloud/agent/manager/AgentManagerImpl.java
@@ -478,7 +478,13 @@ public List<HostVO> discoverHosts(long dcId, Long podId, Long clusterId, URI url
         Enumeration<Discoverer> en = _discoverers.enumeration();
         while (en.hasMoreElements()) {
             Discoverer discoverer = en.nextElement();
-            Map<? extends ServerResource, Map<String, String>> resources = discoverer.find(dcId, podId, clusterId, url, username, password);
+            Map<? extends ServerResource, Map<String, String>> resources = null;
+            
+            try {
+            	resources = discoverer.find(dcId, podId, clusterId, url, username, password);
+            } catch(Exception e) {
+            	s_logger.info("Exception in host discovery process with discoverer: " + discoverer.getName() + ", skip to another discoverer if there is any");
+            }
             if (resources != null) {
                 for (Map.Entry<? extends ServerResource, Map<String, String>> entry : resources.entrySet()) {
                     ServerResource resource = entry.getKey();
@@ -1677,7 +1683,7 @@ protected void updateHost(final HostVO host, final StartupCommand startup, final
 
             // If this command is from a KVM agent, or from an agent that has a
             // null hypervisor type, don't do the CIDR check
-            if (hypervisorType == null || hypervisorType == Hypervisor.Type.KVM)
+            if (hypervisorType == null || hypervisorType == Hypervisor.Type.KVM || hypervisorType == Hypervisor.Type.VMware)
                 doCidrCheck = false;
 
             if (doCidrCheck)
diff --git a/setup/db/templates.xenserver.sql b/setup/db/templates.xenserver.sql
@@ -72,3 +72,6 @@ INSERT INTO `cloud`.`guest_os` (id, category_id, name, display_name) VALUES (58,
 INSERT INTO `cloud`.`guest_os` (id, category_id, name, display_name) VALUES (59, 7, 'Other install media', 'Ubuntu');
 INSERT INTO `cloud`.`guest_os` (id, category_id, name, display_name) VALUES (60, 7, 'Other install media', 'Other');
 
+-- temporarily added for vmware, will be moved when vmware support is fully in-place
+INSERT INTO `cloud`.`host_master`(`type`, `service_address`, `admin`, `password`) VALUES('VSphere', 'vsphere-1.lab.vmops.com', 'Administrator', 'Suite219');
+

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@ public static enum Type {`
`23`	`23`	`None, //for storage hosts`
`24`	`24`	`Xen,`
`25`	`25`	`XenServer,`
`26`		`- KVM;`
	`26`	`+ KVM,`
	`27`	`+ VMware;`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4114,6 +4114,7 @@ protected void fillHostInfo(StartupRoutingCommand cmd) {`
`4114`	`4114`	`break;`
`4115`	`4115`	`}`
`4116`	`4116`	`}`
	`4117`	`+`
`4117`	`4118`	`// assume the memory Virtualization overhead is 1/64`
`4118`	`4119`	`ram = (ram - dom0Ram) * 63/64;`
`4119`	`4120`	`cmd.setMemory(ram);`