bug CS-14593, CS-14541: fixed encryption issue

Abhi · Abhi · commit 685775056621 · 2012-04-23T15:29:38.000+05:30
diff --git a/server/src/com/cloud/configuration/ConfigurationManagerImpl.java b/server/src/com/cloud/configuration/ConfigurationManagerImpl.java
@@ -1262,44 +1262,44 @@ public boolean updateLDAP(LDAPConfigCmd cmd) {
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.hostname.toString(), null, "Hostname or ip address of the ldap server eg: my.ldap.com");
             }
-            cvo.setValue(hostname);
+            cvo.setValue(DBEncryptionUtil.encrypt(hostname));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.port.toString());
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.port.toString(), null, "Specify the LDAP port if required, default is 389");
             }
-            cvo.setValue(port.toString());
+            cvo.setValue(DBEncryptionUtil.encrypt(port.toString()));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.queryfilter.toString());
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.queryfilter.toString(), null,
                         "You specify a query filter here, which narrows down the users, who can be part of this domain");
             }
-            cvo.setValue(queryFilter);
+            cvo.setValue(DBEncryptionUtil.encrypt(queryFilter));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.searchbase.toString());
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.searchbase.toString(), null,
                         "The search base defines the starting point for the search in the directory tree Example:  dc=cloud,dc=com.");
             }
-            cvo.setValue(searchBase);
+            cvo.setValue(DBEncryptionUtil.encrypt(searchBase));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.usessl.toString());
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.usessl.toString(), null, "Check Use SSL if the external LDAP server is configured for LDAP over SSL.");
             }
-            cvo.setValue(useSSL.toString());
+            cvo.setValue(DBEncryptionUtil.encrypt(useSSL.toString()));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.dn.toString());
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.dn.toString(), null, "Specify the distinguished name of a user with the search permission on the directory");
             }
-            cvo.setValue(bindDN);
+            cvo.setValue(DBEncryptionUtil.encrypt(bindDN));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.passwd.toString());
@@ -1313,7 +1313,7 @@ public boolean updateLDAP(LDAPConfigCmd cmd) {
             if (cvo == null) {
                 cvo = new ConfigurationVO("Hidden", "DEFAULT", "management-server", LDAPParams.truststore.toString(), null, "Enter the path to trusted keystore");
             }
-            cvo.setValue(trustStore);
+            cvo.setValue(DBEncryptionUtil.encrypt(trustStore));
             _configDao.persist(cvo);
 
             cvo = _configDao.findByName(LDAPParams.truststorepass.toString());
diff --git a/server/src/com/cloud/server/auth/LDAPUserAuthenticator.java b/server/src/com/cloud/server/auth/LDAPUserAuthenticator.java
@@ -67,9 +67,9 @@ public boolean authenticate(String username, String password, Long domainId, Map
         String searchBase = _configDao.getValue(LDAPParams.searchbase.toString());
         String useSSL = _configDao.getValue(LDAPParams.usessl.toString());
         String bindDN = _configDao.getValue(LDAPParams.dn.toString());
-        String bindPasswd = DBEncryptionUtil.decrypt(_configDao.getValue(LDAPParams.passwd.toString()));
+        String bindPasswd = _configDao.getValue(LDAPParams.passwd.toString());
         String trustStore = _configDao.getValue(LDAPParams.truststore.toString());
-        String trustStorePassword = DBEncryptionUtil.decrypt(_configDao.getValue(LDAPParams.truststorepass.toString()));
+        String trustStorePassword = _configDao.getValue(LDAPParams.truststorepass.toString());
         
         try {
             // get all params
