Skip to content

Fetch - #459

Open
Samuel-Drei wants to merge 6 commits into
javascript-tutorial:masterfrom
Samuel-Drei:master
Open

Fetch#459
Samuel-Drei wants to merge 6 commits into
javascript-tutorial:masterfrom
Samuel-Drei:master

Conversation

@Samuel-Drei

Copy link
Copy Markdown

No description provided.

@CLAassistant

CLAassistant commented May 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@gabifs gabifs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valeu pela tradução, Samuel! O texto ficou muito bom — identificadores preservados, links info: mantidos, marcadores *!* intactos e o callout warn aninhado correto.

Só tem um bloqueante: as cercas de código do artigo foram trocadas de ``` para ````. Deixei o detalhe inline. Fora isso, três ajustes de consistência e dois nits.

A sintaxe básica é a seguinte:

```js
````js

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 As cercas de código do artigo foram trocadas de três para quatro crases em 13 blocos. No repositório inteiro não existe nenhum outro js / html — as quatro crases são reservadas para callouts que envolvem uma cerca aninhada (o ````warn da linha 124, que você manteve certo).

Dois problemas: (1) o engine pode não reconhecer as flags run / autorun / height="90" numa cerca de 4 crases, matando os botões de demo silenciosamente; (2) todo merge futuro de sync-<sha> vai conflitar nesses 13 blocos.

Pares a reverter: 22/24, 48/57, 72/81, 85/89, 93/99, 103/122, 141/151, 157/163, 205/223, 235/262, 268/279, 285/288, 292/296. Manter 124 e 133 (o warn).

Dá pra corrigir tudo de uma vez:

awk 'NR==124||NR==133{print;next} {sub(/^````/,"```")} 1' \
  5-network/01-fetch/article.md > /tmp/a && mv /tmp/a 5-network/01-fetch/article.md

Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment thread 5-network/01-fetch/article.md Outdated
Comment on lines +144 to +147
// obtém um cabeçalho específico
alert(response.headers.get('Content-Type')); // application/json; charset=utf-8

// iterate over all headers
// itera sobre todos os cabeçalhos

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Mesma padronização de headers (a sugestão cobre as duas linhas de comentário).

Suggested change
// obtém um cabeçalho específico
alert(response.headers.get('Content-Type')); // application/json; charset=utf-8
// iterate over all headers
// itera sobre todos os cabeçalhos
// obtém um header específico
alert(response.headers.get('Content-Type')); // application/json; charset=utf-8
// itera sobre todos os headers

Comment thread 5-network/01-fetch/article.md
Comment thread 5-network/01-fetch/article.md Outdated
Samuel-Drei and others added 5 commits September 7, 2026 13:36
Co-authored-by: Gabriel Fernandes <ga3riel.fernandess@gmail.com>
Co-authored-by: Gabriel Fernandes <ga3riel.fernandess@gmail.com>
Co-authored-by: Gabriel Fernandes <ga3riel.fernandess@gmail.com>
Co-authored-by: Gabriel Fernandes <ga3riel.fernandess@gmail.com>
Co-authored-by: Gabriel Fernandes <ga3riel.fernandess@gmail.com>

@wesleysilva02 wesleysilva02 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants