Repository navigation
Fixes for 1471-1477 - #1481
Merged
Merged
Fixes for 1471-1477#1481
Conversation
…ns into `var` inside functions passed as call arguments or used as operands, when `var` is the prevailing kind of variables. Fixes #1471 * Fixed `controlFlowFlattening` turning a `#x in obj` private brand check into invalid code. Fixes #1472 * Fixed an escaped `'use\x20strict'` directive being emitted as an actual `'use strict'` directive. Fixes #1474 * Fixed `selfDefending`, `disableConsoleOutput`, `debugProtection` and `domainLock` code helpers being placed before the `'use strict'` directive, which disabled strict mode. Fixes #1475 * Fixed `numbersToExpressions` producing invalid code for non-computed numeric keys of class members. Fixes #1476 * Template literals are now transformed into `String.prototype.concat` calls instead of `+` concatenation, so substitutions are converted to strings with `toString` instead of `valueOf`. Fixes #1477
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
controlFlowFlatteningchangingletandconstdeclarations intovarinside functions passed as call arguments or used as operands, whenvaris the prevailing kind of variables. Fixes controlFlowFlattening rewrites let/const to var inside functions passed to wrapped calls #1471controlFlowFlatteningturning a#x in objprivate brand check into invalid code. Fixes controlFlowFlattening turns#x in objintofn(#x, obj), causing a SyntaxError #1472'use\x20strict'directive being emitted as an actual'use strict'directive. Fixes Escaped "use\x20strict" in directive prologue is emitted as 'use strict' #1474selfDefending,disableConsoleOutput,debugProtectionanddomainLockcode helpers being placed before the'use strict'directive, which disabled strict mode. Fixes Custom code helpers are prepended before 'use strict', disabling strict mode #1475numbersToExpressionsproducing invalid code for non-computed numeric keys of class members. Fixes numbersToExpressions produces invalid syntax for numeric class member keys #1476String.prototype.concatcalls instead of+concatenation, so substitutions are converted to strings withtoStringinstead ofvalueOf. Fixes Template literals are lowered to + concatenation, calling valueOf instead of toString #1477