Repository navigation
Conversation
- Validate an empty string inside the URL check instead of `ValidateIf`, so it is still checked by `IsAllowedForObfuscationTargets` and rejected for the `node` target like any other value - Mention the empty string behaviour in the `--domain-lock-redirect-url` CLI help - Move the CHANGELOG entry out of the released v5.10.0 section into v5.11.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1217
Currently domainLockRedirectUrl rejects empty strings during validation, and simply allowing '' in the existing template would assign document.location = '' (which reloads the current page instead of halting execution).
This PR allows passing '' to domainLockRedirectUrl and updates DomainLockTemplate at compile-time to throw an error instead of redirecting when no redirect URL is provided. It also skips the unnecessary hideString step when the URL is empty.
Added unit tests covering validation, normalizer rules, and template behavior.