Repository navigation
Replace multimatch with minimatch@11 to resolve GHSA-g3hv-75wg-m249 - #1469
Merged
sanex3339 merged 2 commits intoNov 4, 2026
Merged
Conversation
…m249` `multimatch@5.0.0` depends on `minimatch@^3`, and every `minimatch` below 11.0.1 is affected by GHSA-g3hv-75wg-m249. Newer `multimatch` versions are ESM-only and still use a vulnerable `minimatch`, so the CLI `--exclude` option now uses `minimatch` directly, keeping multimatch's ordered `!`-negation semantics and its Windows `\` separator handling. `minimatch@11` requires Node.js 20, so `engines.node` is now `>=20.0.0`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sanex3339
reviewed
Nov 4, 2026
Comment on lines
+3
to
+6
| v5.10.0 | ||
| --- | ||
| * Replaced `multimatch` with `minimatch@11` for the CLI `--exclude` option, resolving the `minimatch` denial of service advisory `GHSA-g3hv-75wg-m249` | ||
| * Require Node.js 20 or newer, as `minimatch@11` does |
Member
There was a problem hiding this comment.
Technically it's a breaking change, but Node 20 is already EOL'ed + it fixes a scanner issue, so it is done as a minor version
Member
|
@jeremy-morren thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multimatch@5.0.0pulls inminimatch@3, which is vulnerable to GHSA-g3hv-75wg-m249 (fixed only in 11.0.1). Bumpingmultimatchdoesn't help: 6+ is ESM-only (#1340) and 8.0.0 still usesminimatch@10. Aresolutionsentry doesn't help either, because consumers ignore it.--excludenow usesminimatchdirectly. Patterns still apply in order with!negation, and\still works as a separator on Windows.brace-expansionresolution.engines.nodeis now>=20: minimatch 11 needs Node 20, Node 18 is EOL, and CI already tests only 20, 22 and 24.The risk is low (it needs a malicious
--excludepattern), but this clears the audit warning for downstream users.Fixes #1468.