Replace mkdirp with native fs.mkdirSync({ recursive: true })#1384
Merged
sanex3339 merged 1 commit intojavascript-obfuscator:masterfrom Mar 22, 2026
Merged
Conversation
Remove the mkdirp dependency in favor of Node's built-in fs.mkdirSync with the recursive option, which has been available since Node 10.12 (repo requires >=18.0.0). Closes javascript-obfuscator#1275 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Thank you! |
sanex3339
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mkdirp(3.0.1) dependency and@types/mkdirp(1.0.2) devDependencyfs.mkdirSync(path, { recursive: true })mkdirp.sync()for test directory setupMotivation
mkdirpis a micro-dependency that wraps functionality available natively in Node.js since v10.12.0.Since this project requires
node >=18.0.0, the native API is always available.Removing
mkdirpreduces the dependency count and attack surface with zero behavior change.Closes #1275
Test plan