add test for segfaults in revwalk

maxkorp · maxkorp · commit ed966eb20e78 · 2014-10-23T09:30:01.000-07:00
diff --git a/generate/partials/sync_function.cc b/generate/partials/sync_function.cc
@@ -1,7 +1,7 @@
 
 {%partial doc .%}
 NAN_METHOD({{ cppClassName }}::{{ cppFunctionName }}) {
-  NanScope();
+  //NanScope();
   {%partial guardArguments .%}
 
   {%each .|returnsInfo 'true' as _return %}
@@ -36,7 +36,7 @@ from_{{ arg.name }}
     {%if not arg.lastArg %},{%endif%}
   {%endeach%}
   );
-
+/*
 {%each args|argsInfo as arg %}
   {%if arg.isCppClassStringOrArray %}
     {%if arg.freeFunctionName %}
@@ -46,7 +46,7 @@ from_{{ arg.name }}
     {%endif%}
   {%endif%}
 {%endeach%}
-
+*/
 {%if return.isErrorCode %}
   if (result != GIT_OK) {
   {%each args|argsInfo as arg %}
diff --git a/test/tests/revwalk.js b/test/tests/revwalk.js
@@ -57,4 +57,32 @@ describe("Revwalk", function() {
       });
     });
   });
+
+  // This test requires forcing garbage collection, so mocha needs to be run via
+  // node rather than npm, with a la `node --expose-gc [pathtohmoca] [testglob]`
+  var testGC = (global.gc ? it : it.skip);
+
+  testGC("doesnt segfault when accessing commit.author() twice", function(done) {
+    this.timeout(10000);
+    return Repository.open(reposPath).then(function(repository) {
+      var walker = repository.createRevWalk();
+      repository.getMaster().then(function(master) {
+        var did = false;
+        walker.walk(master, function(error, commit) {
+          for (var i = 0; i < 1000; i++) {
+            if (true) {
+              commit.author().name();
+              commit.author().email();
+            }
+            global.gc();
+          }
+          if (!did) {
+            done();
+            did = true;
+          }
+        });
+      });
+    });
+  });
+
 });
