Introduced a new segfault woot

tbranyen · tbranyen · commit de04c08e53e2 · 2014-10-23T10:47:34.000-04:00
diff --git a/generate/descriptor.json b/generate/descriptor.json
@@ -692,6 +692,9 @@
     "fields": [{
       "name": "version",
       "cType": "int"
+    }, {
+      "name": "credentials",
+      "cType": "function"
     }]
   },
 
diff --git a/lib/clone.js b/lib/clone.js
@@ -12,8 +12,12 @@ var clone = Clone.clone;
  * @param options
  */
 Clone.clone = function(url, local_path, options) {
-  options = normalizeOptions(options, NodeGit.CloneOptions);
-  return clone.call(this, url, local_path, options);
+  //var opts = normalizeOptions(options, NodeGit.CloneOptions);
+  //opts = normalizeOptions(options.remote_callbacks, NodeGit.RemoteCallbacks);
+
+  var callbacks = new NodeGit.RemoteCallbacks();
+  console.log(callbacks);
+  //return clone.call(this, url, local_path, opts);
 };
 
 module.exports = Clone;
diff --git a/lib/nodegit.js b/lib/nodegit.js
@@ -2,6 +2,8 @@ var promisify = require("promisify-node");
 var descriptors = require("../generate/idefs.json");
 var rawApi;
 
+//require("segfault_handler").registerHandler();
+
 // Attempt to load the production release first, if it fails fall back to the
 // debug release.
 try {
diff --git a/package.json b/package.json
@@ -72,8 +72,9 @@
   },
   "scripts": {
     "lint": "jshint lib test/tests",
-    "mocha": "istanbul cover node_modules/mocha/bin/_mocha -- test/runner test/tests --report=lcov",
-    "test": "npm run lint && npm run mocha",
+    "cov": "istanbul cover node_modules/mocha/bin/_mocha -- test/runner test/tests --report=lcov",
+    "mocha": "mocha test/runner test/tests",
+    "test": "npm run lint && npm run cov",
     "publish": "node-pre-gyp package && node-pre-gyp publish",
     "generate": "node generate/setup && node generate",
     "install": "npm run generate && node install",
diff --git a/test/tests/clone.js b/test/tests/clone.js
@@ -42,9 +42,17 @@ describe("Clone", function() {
     });
   });
 
-  it("can clone with ssh", function() {
+  it.only("can clone with ssh", function() {
     var url = "git@github.com:nodegit/test.git";
-    var opts = { ignoreCertErrors: 1 };
+    var opts = {
+      ignoreCertErrors: 1,
+      remote_callbacks: {
+        credentials: function() {
+          console.log("here");
+          return null;
+        }
+      }
+    };
 
     return Clone.clone(url, ssh, opts).then(function(repository) {
       assert.ok(repository instanceof Repository);
