Removed a new segfault woot

John Haley · tbranyen · commit d6a2fed4abee · 2014-10-23T10:47:34.000-04:00
diff --git a/generate/descriptor.json b/generate/descriptor.json
@@ -282,6 +282,10 @@
     "isStruct": true
   },
 
+  "cred_acquire_cb": {
+    
+  },
+
   "cred_helpers": {
   },
 
@@ -694,7 +698,7 @@
       "cType": "int"
     }, {
       "name": "credentials",
-      "cType": "function"
+      "cType": "git_cred_acquire_cb"
     }]
   },
 
diff --git a/generate/types.json b/generate/types.json
@@ -1,4 +1,8 @@
 {
+  "git_cred_acquire_cb": {
+    "cpp": "Function",
+    "js": "Function"
+  },
   "git_attr_get": {
     "cpp": "Get",
     "js": "get"
@@ -9224,4 +9228,4 @@
     "cpp": "CredSshKeyFromAgent",
     "js": "credSshKeyFromAgent"
   }
-}
+}
diff --git a/lib/clone.js b/lib/clone.js
@@ -12,12 +12,8 @@ var clone = Clone.clone;
  * @param options
  */
 Clone.clone = function(url, local_path, options) {
-  //var opts = normalizeOptions(options, NodeGit.CloneOptions);
-  //opts = normalizeOptions(options.remote_callbacks, NodeGit.RemoteCallbacks);
-
-  var callbacks = new NodeGit.RemoteCallbacks();
-  console.log(callbacks);
-  //return clone.call(this, url, local_path, opts);
+  options = normalizeOptions(options, NodeGit.CloneOptions);
+  return clone.call(this, url, local_path, options);
 };
 
 module.exports = Clone;
diff --git a/lib/nodegit.js b/lib/nodegit.js
@@ -2,8 +2,6 @@ var promisify = require("promisify-node");
 var descriptors = require("../generate/idefs.json");
 var rawApi;
 
-//require("segfault_handler").registerHandler();
-
 // Attempt to load the production release first, if it fails fall back to the
 // debug release.
 try {

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,8 @@`
`1`	`1`	`{`
	`2`	`+ "git_cred_acquire_cb": {`
	`3`	`+ "cpp": "Function",`
	`4`	`+ "js": "Function"`
	`5`	`+ },`
`2`	`6`	`"git_attr_get": {`
`3`	`7`	`"cpp": "Get",`
`4`	`8`	`"js": "get"`
`@@ -9224,4 +9228,4 @@`
`9224`	`9228`	`"cpp": "CredSshKeyFromAgent",`
`9225`	`9229`	`"js": "credSshKeyFromAgent"`
`9226`	`9230`	`}`
`9227`		`-}`
	`9231`	`+}`