Skip to content

Commit c331c2b

Browse files
maxkorpmaxkorp
committed
Merge pull request nodegit#358 from nodegit/lint-examples
Lint examples
2 parents ccca4d3 + 1eaf5bc commit c331c2b

28 files changed

+818
-691
lines changed

‎.npmignore‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
/build/
22
/example/
3+
/examples/
34
/generate/
45
/test/
56
/vendor/libgit2/

‎TESTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ In the file each `{className}` corresponds to a file found at `test/tests/{class
3434

3535
In the file that your test is going in you can just append it to the file inside of the `describe` function block.
3636

37-
It can be helpful to reference the [libgit2 API docs](https://libgit2.github.com/libgit2/#v0.21.2) to know what the field or function is doing inside of libgit2 and referencing the [NodeGit API docs](http://www.nodegit.org/) can also help. Looking at examples inside of `/example` can show you how we wrap the libgit2 library and how you can call into it from JavaScript.
37+
It can be helpful to reference the [libgit2 API docs](https://libgit2.github.com/libgit2/#v0.21.2) to know what the field or function is doing inside of libgit2 and referencing the [NodeGit API docs](http://www.nodegit.org/) can also help. Looking at examples inside of `/examples` can show you how we wrap the libgit2 library and how you can call into it from JavaScript.
3838

3939
The idea is to test the basic functionality of the field/function and to confirm that it's returning or setting the value(s) correctly. Bugs inside of libgit2 will have to either have a work-around or be ignored.
4040

‎example/details-for-tree-entry.js‎

Lines changed: 0 additions & 28 deletions
This file was deleted.

‎example/fetch.js‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎example/general.js‎

Lines changed: 0 additions & 314 deletions
This file was deleted.

‎example/pull.js‎

Lines changed: 0 additions & 26 deletions
This file was deleted.

0 commit comments

Comments
 (0)