Added in optional ignore cert param for fetching

John Haley · John Haley · commit c1ff5faec096 · 2014-12-05T11:04:42.000-07:00
diff --git a/lib/repository.js b/lib/repository.js
@@ -512,11 +512,17 @@ Repository.prototype.getRemote = function(remote, callback) {
  *
  * @param {String|Remote} remote
  */
-Repository.prototype.fetch = function(remote, remoteCallbacks, callback) {
+Repository.prototype.fetch = function(
+  remote,
+  remoteCallbacks,
+  ignoreCertErrors,
+  callback)
+{
   var repo = this;
 
   return repo.getRemote(remote).then(function(remote) {
     remote.setCallbacks(remoteCallbacks);
+    remote.checkCert(ignoreCertErrors ? 0 : 1);
 
     return remote.fetch(repo.defaultSignature(), "Fetch from " + remote)
     .then(function() {
@@ -530,14 +536,19 @@ Repository.prototype.fetch = function(remote, remoteCallbacks, callback) {
 /**
  * Fetches from all remotes
  */
-Repository.prototype.fetchAll = function(remoteCallbacks, callback) {
+Repository.prototype.fetchAll = function(
+  remoteCallbacks,
+  ignoreCertErrors,
+  callback)
+{
   var repo = this;
 
   return repo.getRemotes().then(function(remotes) {
     var fetchPromises = [];
 
     remotes.forEach(function(remote) {
-      fetchPromises.push(repo.fetch(remote, remoteCallbacks, callback));
+      fetchPromises.push(
+        repo.fetch(remote, remoteCallbacks, ignoreCertErrors, callback));
     });
 
     return Promise.all(fetchPromises);
diff --git a/test/tests/remote.js b/test/tests/remote.js
@@ -108,6 +108,15 @@ describe("Remote", function() {
       credentials: function(url, userName) {
         return NodeGit.Cred.sshKeyFromAgent(userName);
       }
-    });
+    }, true);
   });
+
+  it("can fetch from all remotes", function() {
+    return this.repository.fetchAll({
+      credentials: function(url, userName) {
+        return NodeGit.Cred.sshKeyFromAgent(userName);
+      }
+    }, true);
+  });
+
 });
