Merge pull request nodegit#424 from nodegit/tighten-up-callbacks

johnhaley81 · johnhaley81 · commit b5b379b4b0ee · 2015-02-27T08:42:07.000-07:00
Fix seg faults
diff --git a/generate/templates/partials/field_accessors.cc b/generate/templates/partials/field_accessors.cc
@@ -38,8 +38,12 @@
         }
 
       {% elsif field.isLibgitType %}
+        Handle<Object> {{ field.name }}(value->ToObject());
         NanDisposePersistent(wrapper->{{ field.name }});
-        wrapper->raw->{{ field.name }} = {% if not field.cType | isPointer %}*{% endif %}ObjectWrap::Unwrap<{{ field.cppClassName }}>(value->ToObject())->GetValue();
+
+        NanAssignPersistent(wrapper->{{ field.name }}, {{ field.name }});
+
+        wrapper->raw->{{ field.name }} = {% if not field.cType | isPointer %}*{% endif %}ObjectWrap::Unwrap<{{ field.cppClassName }}>({{ field.name }}->ToObject())->GetValue();
 
       {% elsif field.isCallbackFunction %}
         if (wrapper->{{ field.name }} != NULL) {
diff --git a/test/tests/status.js b/test/tests/status.js
@@ -14,9 +14,8 @@ describe("Status", function() {
 
   var reposPath = local("../repos/workdir/.git");
 
-  beforeEach(function() {
+  before(function() {
     var test = this;
-    delete test.repository;
     return Repository.open(reposPath)
       .then(function(repository) {
         test.repository = repository;
