Skip to content

Commit ae18fa0

Browse files
committed
Fixes for OS X, remove remote_path.
1 parent 4d703c7 commit ae18fa0

3 files changed

Lines changed: 14 additions & 25 deletions

File tree

binding.gyp

Lines changed: 11 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -50,31 +50,18 @@
5050
],
5151

5252
"cflags": [
53-
"-Wall"
54-
],
55-
56-
"ldflags": [
57-
"-Wl,-rpath,\$$ORIGIN/Release/"
53+
"-Wall",
5854
],
5955

6056
"conditions": [
61-
[
62-
"OS=='win'", {
63-
"libraries": [
64-
"-lRelease/libgit2.lib"
65-
],
66-
}, { # 'OS!="win"'
67-
"libraries": [
68-
"-L<!(pwd)/build/Release",
69-
"-lgit2"
70-
]
71-
}
72-
],
73-
7457
[
7558
"OS=='mac'", {
7659
"xcode_settings": {
77-
"GCC_ENABLE_CPP_EXCEPTIONS": "YES"
60+
"GCC_ENABLE_CPP_EXCEPTIONS": "YES",
61+
62+
"WARNING_CFLAGS": [
63+
"-Wno-unused-variable",
64+
],
7865
}
7966
}
8067
]
@@ -343,12 +330,15 @@
343330
],
344331
'cflags': [
345332
'-Wno-missing-field-initializers',
346-
'-Wno-unused-variable'
333+
'-Wno-unused-variable',
334+
'-Wno-deprecated-declarations',
347335
],
348336
'xcode_settings': {
349337
'WARNING_CFLAGS': [
350338
'-Wno-missing-field-initializers',
351-
'-Wno-unused-variable'
339+
'-Wno-unused-variable',
340+
'-Wno-deprecated-declarations',
341+
'-Wno-uninitialized',
352342
],
353343
},
354344
},

install.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ var dependencies = Q.allSettled([
5959
// work with Python 2.* if it's available.
6060
Q.nfcall(which, 'python2'),
6161
Q.nfcall(which, 'python'),
62-
62+
6363
// Check for any version of CMake.
6464
Q.nfcall(which, 'cmake'),
6565
])
@@ -71,7 +71,7 @@ var dependencies = Q.allSettled([
7171
// Assign to reusable variables.
7272
python = results[0].value || results[1].value;
7373
cmake = results[2].value;
74-
74+
7575
// Now lets check the Python version to ensure it's < 3.
7676
return Q.nfcall(exec, python + ' --version').then(function(version) {
7777
if (version[1].indexOf('Python 3') === 0) {

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,7 @@
5454
"binary": {
5555
"module_name": "nodegit",
5656
"module_path": "./build/Release/",
57-
"host": "https://s3.amazonaws.com/nodegit/nodegit/",
58-
"remote_path": "../"
57+
"host": "https://s3.amazonaws.com/nodegit/nodegit/"
5958
},
6059
"scripts": {
6160
"lint": "jshint src",

0 commit comments

Comments
 (0)