make index.addAll use status to speed up

maxkorp · maxkorp · commit a8fd0459f2a8 · 2015-03-09T11:11:21.000-07:00
diff --git a/lib/index.js b/lib/index.js
@@ -1,7 +1,8 @@
 var NodeGit = require("../");
 
 var Index = NodeGit.Index;
-
+var Status = NodeGit.Status;
+var Promise = require("nodegit-promise");
 /**
  * Return an array of the entries in this index.
  * @return {Array<IndexEntry>} an array of IndexEntrys
@@ -19,7 +20,21 @@ Index.prototype.entries = function() {
 
 var addAll = Index.prototype.addAll;
 Index.prototype.addAll = function(pathspec, flags, matchedCallback) {
-  return addAll.call(this, pathspec || "*", flags, matchedCallback, null);
+  // This status path code is here to speedup addall, which currently is
+  // excessively slow due to adding every single unignored file to the index
+  // even if it has no changes. Remove this when it's fixed in libgit2
+  // https://github.com/libgit2/libgit2/issues/2687
+  var paths = [];
+  var statusCB = function(path) {
+    paths.push(path);
+  };
+  return Status.foreach(this.owner(), statusCB)
+    .then(function() {
+      return Promise.resolve(paths);
+    })
+    .then(function(paths) {
+      return addAll.call(this, pathspec || "*", flags, matchedCallback, null);
+    });
 };
 
 var removeAll = Index.prototype.removeAll;
