Skip to content

Commit 749826c

Browse files
tbranyenJohn Haley
authored andcommitted
Attempt to fix Windows file locking bug
1 parent d439162 commit 749826c

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

generate/input/descriptor.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1431,9 +1431,6 @@
14311431
"git_repository_fetchhead_foreach": {
14321432
"ignore": true
14331433
},
1434-
"git_repository_free": {
1435-
"ignore": true
1436-
},
14371434
"git_repository_hashfile": {
14381435
"ignore": true
14391436
},

generate/scripts/helpers.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -288,8 +288,8 @@ var Helpers = {
288288
// available
289289
if (key == typeDef.cType + "_free") {
290290
typeDef.freeFunctionName = key;
291-
fnDef.ignore = true;
292-
return;
291+
//fnDef.ignore = true;
292+
//return;
293293
}
294294

295295
fnDef.cppFunctionName = Helpers.cTypeToCppName(key, "git_" + typeDef.typeName);

test/tests/clone.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,9 @@ describe("Clone", function() {
2828
fse.remove(ssh),
2929
fse.remove(git),
3030
fse.remove(file)
31-
]).catch(function unhandledFunction() {});
31+
]).catch(function unhandledFunction(ex) {
32+
console.log(ex.message);
33+
});
3234
});
3335

3436
it.skip("can clone with http", function() {
@@ -43,6 +45,7 @@ describe("Clone", function() {
4345

4446
return Clone.clone(url, http, opts).then(function(repo) {
4547
assert.ok(repo instanceof Repository);
48+
repo.free();
4649
});
4750
});
4851

@@ -58,6 +61,8 @@ describe("Clone", function() {
5861

5962
return Clone.clone(url, https, opts).then(function(repo) {
6063
assert.ok(repo instanceof Repository);
64+
repo.stateCleanup();
65+
repo.free();
6166
});
6267
});
6368

@@ -76,6 +81,8 @@ describe("Clone", function() {
7681

7782
return Clone.clone(url, ssh, opts).then(function(repo) {
7883
assert.ok(repo instanceof Repository);
84+
repo.stateCleanup();
85+
repo.free();
7986
});
8087
});
8188

@@ -98,6 +105,8 @@ describe("Clone", function() {
98105

99106
return Clone.clone(url, ssh, opts).then(function(repo) {
100107
assert.ok(repo instanceof Repository);
108+
repo.stateCleanup();
109+
repo.free();
101110
});
102111
});
103112

@@ -113,6 +122,8 @@ describe("Clone", function() {
113122

114123
return Clone.clone(url, git, opts).then(function(repo) {
115124
assert.ok(repo instanceof Repository);
125+
repo.stateCleanup();
126+
repo.free();
116127
});
117128
});
118129

@@ -122,6 +133,8 @@ describe("Clone", function() {
122133

123134
return Clone.clone(url, file).then(function(repo) {
124135
assert.ok(repo instanceof Repository);
136+
repo.stateCleanup();
137+
repo.free();
125138
});
126139
});
127140

0 commit comments

Comments
 (0)