Fixed some things with Tags being looked up

John Haley · John Haley · commit 57658ecae838 · 2014-11-18T17:24:16.000-07:00
diff --git a/generate/descriptor.json b/generate/descriptor.json
@@ -127,6 +127,9 @@
             "cppClassName": "Array",
             "jsClassName": "Array",
             "arrayElementCppClassName": "GitCommit"
+          },
+          "update_ref": {
+            "isOptional": true
           }
         }
       },
@@ -1079,6 +1082,13 @@
     "functions": {
       "git_tag_foreach": {
         "ignore": true
+      },
+      "git_tag_target": {
+        "args": {
+          "target_out": {
+            "isReturn": true
+          }
+        }
       }
     }
   },
diff --git a/lib/repository.js b/lib/repository.js
@@ -2,10 +2,12 @@ var NodeGit = require("../");
 var normalizeOid = require("./util/normalize_oid");
 var Blob = require("./blob");
 var Tree = require("./tree");
+var Tag = require("./tag");
 var Reference = require("./refs");
 var Revwalk = require("./revwalk");
 var Commit = require("./commit");
 var Remote = require("./remote");
+var Promise = require("nodegit-promise");
 
 var TreeBuilder = NodeGit.Treebuilder;
 var Repository = NodeGit.Repository;
@@ -163,7 +165,7 @@ Repository.prototype.getTag = function(oid, callback) {
 
   var repository = this;
 
-  return Reference.lookup(repository, oid).then(function(reference) {
+  return Tag.lookup(repository, oid).then(function(reference) {
     reference.repo = repository;
 
     if (typeof callback === "function") {
@@ -214,21 +216,22 @@ Repository.prototype.createCommit = function(
   updateRef, author, committer, message, tree, parents, callback) {
 
   var createCommit = null;
-  var commit = this;
   var repo = this;
 
   if (tree instanceof Tree) {
-    commit = Commit.create(
-      repo,
-      updateRef,
-      author,
-      committer,
-      null /* use default message encoding */,
-      message,
-      tree,
-      parents.length,
-      parents
-    );
+    createCommit = Promise.all([
+      Commit.create(
+        repo,
+        updateRef,
+        author,
+        committer,
+        null /* use default message encoding */,
+        message,
+        tree,
+        parents.length,
+        parents
+      )
+    ]);
   } else {
     createCommit = this.getTree(tree).then(function(tree) {
       return Commit.create(
diff --git a/lib/tag.js b/lib/tag.js
@@ -0,0 +1,5 @@
+var git = require("../");
+
+var Tag = git.Tag;
+
+module.exports = Tag;

Original file line number	Diff line number	Diff line change
`@@ -127,6 +127,9 @@`
`127`	`127`	`"cppClassName": "Array",`
`128`	`128`	`"jsClassName": "Array",`
`129`	`129`	`"arrayElementCppClassName": "GitCommit"`
	`130`	`+ },`
	`131`	`+ "update_ref": {`
	`132`	`+ "isOptional": true`
`130`	`133`	`}`
`131`	`134`	`}`
`132`	`135`	`},`
`@@ -1079,6 +1082,13 @@`
`1079`	`1082`	`"functions": {`
`1080`	`1083`	`"git_tag_foreach": {`
`1081`	`1084`	`"ignore": true`
	`1085`	`+ },`
	`1086`	`+ "git_tag_target": {`
	`1087`	`+ "args": {`
	`1088`	`+ "target_out": {`
	`1089`	`+ "isReturn": true`
	`1090`	`+ }`
	`1091`	`+ }`
`1082`	`1092`	`}`
`1083`	`1093`	`}`
`1084`	`1094`	`},`