Expose AllocStrArray

mattyclarkson · mattyclarkson · commit 3e5cb89b9f49 · 2015-03-03T15:07:53.000Z
diff --git a/generate/templates/manual/include/str_array_converter.h b/generate/templates/manual/include/str_array_converter.h
@@ -16,6 +16,7 @@ class StrArrayConverter {
   private:
     static git_strarray *ConvertArray(Array *val);
     static git_strarray *ConvertString(Handle<String> val);
+    static git_strarray *AllocStrArray(const size_t count);
     static git_strarray *ConstructStrArray(int argc, char** argv);
 };
 
diff --git a/generate/templates/manual/src/str_array_converter.cc b/generate/templates/manual/src/str_array_converter.cc
@@ -24,7 +24,7 @@ git_strarray *StrArrayConverter::Convert(Handle<v8::Value> val) {
   }
 }
 
-static git_strarray * AllocGitStrArray(const size_t count) {
+static git_strarray * StrArrayConverter::AllocStrArray(const size_t count) {
   const size_t size = sizeof(git_strarray) + (sizeof(char*) * count);
   uint8_t* memory = reinterpret_cast<uint8_t*>(malloc(size));
   git_strarray *result = reinterpret_cast<git_strarray *>(memory);
@@ -34,7 +34,7 @@ static git_strarray * AllocGitStrArray(const size_t count) {
 }
 
 git_strarray *StrArrayConverter::ConvertArray(Array *val) {
-  git_strarray *result = AllocGitStrArray(val->Length());
+  git_strarray *result = AllocStrArray(val->Length());
 
   for(size_t i = 0; i < result->count; i++) {
     NanUtf8String entry(val->Get(i));
@@ -54,7 +54,7 @@ git_strarray* StrArrayConverter::ConvertString(Handle<String> val) {
 }
 
 git_strarray *StrArrayConverter::ConstructStrArray(int argc, char** argv) {
-  git_strarray *result = AllocGitStrArray(argc);
+  git_strarray *result = AllocStrArray(argc);
 
   for(size_t i = 0; i < result->count; i++) {
     result->strings[i] = strdup(argv[i]);

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ git_strarray *StrArrayConverter::Convert(Handle<v8::Value> val) {`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`
`27`		`-static git_strarray * AllocGitStrArray(const size_t count) {`
	`27`	`+static git_strarray * StrArrayConverter::AllocStrArray(const size_t count) {`
`28`	`28`	`const size_t size = sizeof(git_strarray) + (sizeof(char) count);`
`29`	`29`	`uint8_t* memory = reinterpret_cast<uint8_t*>(malloc(size));`
`30`	`30`	`git_strarray result = reinterpret_cast<git_strarray >(memory);`
`@@ -34,7 +34,7 @@ static git_strarray * AllocGitStrArray(const size_t count) {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`git_strarray StrArrayConverter::ConvertArray(Array val) {`
`37`		`- git_strarray *result = AllocGitStrArray(val->Length());`
	`37`	`+ git_strarray *result = AllocStrArray(val->Length());`
`38`	`38`
`39`	`39`	`for(size_t i = 0; i < result->count; i++) {`
`40`	`40`	`NanUtf8String entry(val->Get(i));`
`@@ -54,7 +54,7 @@ git_strarray* StrArrayConverter::ConvertString(Handle<String> val) {`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`git_strarray StrArrayConverter::ConstructStrArray(int argc, char* argv) {`
`57`		`- git_strarray *result = AllocGitStrArray(argc);`
	`57`	`+ git_strarray *result = AllocStrArray(argc);`
`58`	`58`
`59`	`59`	`for(size_t i = 0; i < result->count; i++) {`
`60`	`60`	`result->strings[i] = strdup(argv[i]);`