Merge pull request iluwatar#269 from iamrichardjones/master

iluwatar · iluwatar · commit a2b8359ab5b8 · 2015-10-20T23:37:39.000+03:00
Add unit test to callback method
diff --git a/callback/src/main/java/com/iluwatar/callback/SimpleTask.java b/callback/src/main/java/com/iluwatar/callback/SimpleTask.java
@@ -9,7 +9,7 @@ public class SimpleTask extends Task {
 
 	@Override
 	public void execute() {
-		System.out.println("Perform some important activity.");
+		System.out.println("Perform some important activity and after call the callback method.");
 	}
 
 }
diff --git a/callback/src/test/java/com/iluwatar/callback/AppTest.java b/callback/src/test/java/com/iluwatar/callback/AppTest.java
@@ -2,18 +2,38 @@
 
 import org.junit.Test;
 
-import com.iluwatar.callback.App;
+import static org.junit.Assert.assertEquals;
 
 /**
- * 
- * Application test
+ * Add a field as a counter. Every time the callback method is called increment this
+ * field. Unit test checks that the field is being incremented.
  *
+ * Could be done with mock objects as well where the call method call is verified.
  */
 public class AppTest {
 
+    private Integer callingCount = 0;
+
 	@Test
 	public void test() {
-		String[] args = {};
-		App.main(args);
+        Callback callback = new Callback() {
+            @Override
+            public void call() {
+                callingCount++;
+            }
+        };
+
+        Task task = new SimpleTask();
+
+        assertEquals("Initial calling count of 0", new Integer(0), callingCount);
+
+        task.executeWith(callback);
+
+        assertEquals("Callback called once", new Integer(1), callingCount);
+
+        task.executeWith(callback);
+
+        assertEquals("Callback called twice", new Integer(2), callingCount);
+
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ public class SimpleTask extends Task {`
`9`	`9`
`10`	`10`	`@Override`
`11`	`11`	`public void execute() {`
`12`		`- System.out.println("Perform some important activity.");`
	`12`	`+ System.out.println("Perform some important activity and after call the callback method.");`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`}`