Code improvements.

iluwatar · iluwatar · commit 8cc843465bf8 · 2015-05-17T21:46:51.000+03:00
diff --git a/thread-pool/src/main/java/com/iluwatar/CoffeeMakingTask.java b/thread-pool/src/main/java/com/iluwatar/CoffeeMakingTask.java
@@ -7,7 +7,7 @@
  */
 public class CoffeeMakingTask extends Task {
 
-	private static int TIME_PER_CUP = 300;
+	private static final int TIME_PER_CUP = 300;
 	
 	public CoffeeMakingTask(int numCups) {
 		super(numCups * TIME_PER_CUP);
diff --git a/thread-pool/src/main/java/com/iluwatar/PotatoPeelingTask.java b/thread-pool/src/main/java/com/iluwatar/PotatoPeelingTask.java
@@ -7,7 +7,7 @@
  */
 public class PotatoPeelingTask extends Task {
 
-	private static int TIME_PER_POTATO = 500;
+	private static final int TIME_PER_POTATO = 500;
 	
 	public PotatoPeelingTask(int numPotatoes) {
 		super(numPotatoes * TIME_PER_POTATO);
diff --git a/thread-pool/src/main/java/com/iluwatar/Task.java b/thread-pool/src/main/java/com/iluwatar/Task.java
@@ -9,10 +9,10 @@ public abstract class Task {
 
 	private static int nextId = 1;
 	
-	private int id;
-	private int timeMs;
+	private final int id;
+	private final int timeMs;
 	
-	public Task(int timeMs) {
+	public Task(final int timeMs) {
 		this.id = nextId++;
 		this.timeMs = timeMs;
 	}
diff --git a/thread-pool/src/main/java/com/iluwatar/Worker.java b/thread-pool/src/main/java/com/iluwatar/Worker.java
@@ -7,9 +7,9 @@
  */
 public class Worker implements Runnable {
 	
-	private Task task;
+	private final Task task;
 
-	public Worker(Task task) {
+	public Worker(final Task task) {
 		this.task = task;
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,9 @@`
`7`	`7`	`*/`
`8`	`8`	`public class Worker implements Runnable {`
`9`	`9`
`10`		`- private Task task;`
	`10`	`+ private final Task task;`
`11`	`11`
`12`		`- public Worker(Task task) {`
	`12`	`+ public Worker(final Task task) {`
`13`	`13`	`this.task = task;`
`14`	`14`	`}`
`15`	`15`