Payara 1939 server events sample - #7
arjantijms merged 3 commits into
Conversation
|
jenkins test please |
| <dependency> | ||
| <groupId>org.glassfish.jersey.media</groupId> | ||
| <artifactId>jersey-media-sse</artifactId> | ||
| <version>2.26</version> |
There was a problem hiding this comment.
org.glassfish.jersey.media dependency can't be here, this is specific for GlassFish ad Payara, but the tests are intended to run on any server
| <version>2.26</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>javax.ws.rs</groupId> |
There was a problem hiding this comment.
javax.ws.rs should be in main pom, and then eventually replaced with Java EE 8 pom
| <dependencies> | ||
| <!-- JSON-B API --> | ||
| <dependency> | ||
| <groupId>javax.json.bind</groupId> |
There was a problem hiding this comment.
javax.json.bind should be in main pom, and then eventually replaced with Java EE 8 pom
| <!-- Yasson (JSON-B RI) --> | ||
| <dependency> | ||
| <groupId>org.eclipse</groupId> | ||
| <artifactId>yasson</artifactId> |
There was a problem hiding this comment.
org.eclipse dependency can't be here, this is specific for GlassFish and Payara, but the tests are intended to run on any server
| * To change this license header, choose License Headers in Project Properties. | ||
| * To change this template file, choose Tools | Templates | ||
| * and open the template in the editor. | ||
| */ |
There was a problem hiding this comment.
This header should not be there
| private String comment; | ||
|
|
||
| public EventData() { | ||
| super(); |
There was a problem hiding this comment.
no need for super() call
| } | ||
|
|
||
| public EventData(String comment) { | ||
| super(); |
There was a problem hiding this comment.
no need for super() call
|
Thanks a lot for the contribution Daniel, I'll merge this in now then ;) |
2 participants
No description provided.