Avoid catching, and printing, Exception.

jglick · jglick · commit eb9d2f1dc49c · 2011-05-24T20:50:11.000Z
Causes fatal errors to be ignored from caller's perspective. http://netbeans.org/bugzilla/show_bug.cgi?id=127368#c44 svn path=/trunk/; revision=85
diff --git a/jhMaster/JSearch/indexer/com/sun/java/help/search/DefaultIndexerKit.java b/jhMaster/JSearch/indexer/com/sun/java/help/search/DefaultIndexerKit.java
@@ -131,6 +131,9 @@ public int parseIntoTokens (String source, int pos) {
 	    }
 	    currentPos += source.length();
 	}
+    catch (RuntimeException e) {
+        throw e;
+    }
 	catch (Exception e) {
 	    e.printStackTrace();
 	}
@@ -139,21 +142,21 @@ public int parseIntoTokens (String source, int pos) {
 
     protected void startStoreDocument (String file) throws Exception {
 	if ((config == null) || (builder == null)) {
-	    throw new Exception("ConfigFile and/or IndexBuilder not set");
+	    throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");
 	}
 	builder.openDocument(config.getURLString(file));
     }
 
     protected void endStoreDocument () throws Exception {
 	if ((config == null) || (builder == null)) {
-	    throw new Exception("ConfigFile and/or IndexBuilder not set");
+	    throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");
 	}
 	builder.closeDocument();
     }
 
     protected void storeToken (String token, int pos) throws Exception {
 	if ((config == null) || (builder == null)) {
-	    throw new Exception("ConfigFile and/or IndexBuilder not set");
+	    throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");
 	}
 	if (!documentStarted) {
 	    try {
@@ -169,7 +172,7 @@ protected void storeToken (String token, int pos) throws Exception {
 
     protected void storeTitle (String title) throws Exception {
 	if ((config == null) || (builder == null)) {
-	    throw new Exception("ConfigFile and/or IndexBuilder not set");
+	    throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");
 	}
 	builder.storeTitle(title);
     }
diff --git a/jhMaster/JSearch/indexer/com/sun/java/help/search/Indexer.java b/jhMaster/JSearch/indexer/com/sun/java/help/search/Indexer.java
@@ -81,14 +81,9 @@ public class Indexer {
      * @param args[]   the command line arguments
      **/
 
-    public static void main(String args[]) {
+    public static void main(String args[]) throws Exception {
 	Indexer compiler = new Indexer();
-	try {
-	    compiler.compile(args);
-	}
-	catch (Exception e) {
-	    e.printStackTrace();
-	}
+    compiler.compile(args);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,9 @@ public int parseIntoTokens (String source, int pos) {`
`131`	`131`	`}`
`132`	`132`	`currentPos += source.length();`
`133`	`133`	`}`
	`134`	`+ catch (RuntimeException e) {`
	`135`	`+ throw e;`
	`136`	`+ }`
`134`	`137`	`catch (Exception e) {`
`135`	`138`	`e.printStackTrace();`
`136`	`139`	`}`
`@@ -139,21 +142,21 @@ public int parseIntoTokens (String source, int pos) {`
`139`	`142`
`140`	`143`	`protected void startStoreDocument (String file) throws Exception {`
`141`	`144`	`if ((config == null) \|\| (builder == null)) {`
`142`		`- throw new Exception("ConfigFile and/or IndexBuilder not set");`
	`145`	`+ throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");`
`143`	`146`	`}`
`144`	`147`	`builder.openDocument(config.getURLString(file));`
`145`	`148`	`}`
`146`	`149`
`147`	`150`	`protected void endStoreDocument () throws Exception {`
`148`	`151`	`if ((config == null) \|\| (builder == null)) {`
`149`		`- throw new Exception("ConfigFile and/or IndexBuilder not set");`
	`152`	`+ throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");`
`150`	`153`	`}`
`151`	`154`	`builder.closeDocument();`
`152`	`155`	`}`
`153`	`156`
`154`	`157`	`protected void storeToken (String token, int pos) throws Exception {`
`155`	`158`	`if ((config == null) \|\| (builder == null)) {`
`156`		`- throw new Exception("ConfigFile and/or IndexBuilder not set");`
	`159`	`+ throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");`
`157`	`160`	`}`
`158`	`161`	`if (!documentStarted) {`
`159`	`162`	`try {`
`@@ -169,7 +172,7 @@ protected void storeToken (String token, int pos) throws Exception {`
`169`	`172`
`170`	`173`	`protected void storeTitle (String title) throws Exception {`
`171`	`174`	`if ((config == null) \|\| (builder == null)) {`
`172`		`- throw new Exception("ConfigFile and/or IndexBuilder not set");`
	`175`	`+ throw new IllegalStateException("ConfigFile and/or IndexBuilder not set");`
`173`	`176`	`}`
`174`	`177`	`builder.storeTitle(title);`
`175`	`178`	`}`