Skip to content

Commit caedce3

Browse files
author
Les Vogel
committed
Fix some samples
1 parent 3219198 commit caedce3

6 files changed

Lines changed: 8 additions & 7 deletions

File tree

.kokoro/system_tests.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ for app in "helloworld" "kotlin-appengine-standard" "kotlin-springboot-appengine
116116
"springboot-appengine-standard" "kotlin-spark-appengine-standard" \
117117
"sparkjava-appengine-standard"
118118
do
119-
(cd "${app}" \
119+
(cd "${app}"; \
120120
mvn appengine:deploy -Dapp.deploy.version="${app}" -Dapp.deploy.project="${GOOGLE_CLOUD_PROJECT}")
121121
done
122122

appengine-standard-java8/kotlin-spark-appengine-standard/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ limitations under the License.
4848
</dependency>
4949
<dependency>
5050
<groupId>org.jetbrains.kotlin</groupId>
51-
<artifactId>kotlin-stdlib</artifactId>
52-
<version>1.1.3-2</version>
51+
<artifactId>kotlin-stdlib-jre8</artifactId>
52+
<version>1.1.4-2</version>
5353
</dependency>
5454
<dependency>
5555
<groupId>com.sparkjava</groupId>
@@ -109,7 +109,7 @@ limitations under the License.
109109
<dependency>
110110
<groupId>org.slf4j</groupId>
111111
<artifactId>slf4j-api</artifactId>
112-
<version>1.8.0-alpha2</version>
112+
<version>1.7.25</version> <!-- TEST if not 1.7.25 -->
113113
</dependency>
114114
</dependencies>
115115

appengine-standard-java8/kotlin-springboot-appengine-standard/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ limitations under the License.
3131

3232
<properties>
3333
<java.version>1.8</java.version>
34-
<kotlin.version>1.1.3-2</kotlin.version>
34+
<kotlin.version>1.1.4-2</kotlin.version>
3535
</properties>
3636

3737
<dependencies>

appengine-standard-java8/kotlin-springboot-appengine-standard/src/main/kotlin/org/jetbrains/kotlin/demo/GreetingController.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,4 @@ class GreetingController {
1414
@GetMapping("/greeting")
1515
fun greeting(@RequestParam(value = "name", defaultValue = "World") name: String) =
1616
Greeting(counter.incrementAndGet(), "Hello, $name, from a SpringBoot Application written in Kotlin, running on Google App Engine Java8 Standard...")
17-
1817
}

appengine-standard-java8/springboot-appengine-standard/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
<dependency>
3232
<groupId>org.springframework.boot</groupId>
3333
<artifactId>spring-boot-starter-web</artifactId>
34+
<version>${spring.boot.version}</version>
3435
<!-- Exclude Tomcat so that it doesn't conflict w/ Jetty server -->
3536
<exclusions>
3637
<exclusion>
@@ -58,6 +59,7 @@
5859
<dependency>
5960
<groupId>org.springframework.boot</groupId>
6061
<artifactId>spring-boot-starter-test</artifactId>
62+
<version>${spring.boot.version}</version>
6163
<scope>test</scope>
6264
</dependency>
6365
</dependencies>

appengine-standard-java8/springboot-appengine-standard/src/main/java/com/example/appengine/demos/springboot/HelloworldController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@
2222
public class HelloworldController {
2323
@GetMapping("/")
2424
public String hello() {
25-
return "Hello world!";
25+
return "Hello world - springboot-appengine-standard!";
2626
}
2727
}

0 commit comments

Comments
 (0)