Profile iOS keypoints in the UINavigationViewController (NativeScript#5108)

PanayotCankov · web-flow · commit ec2ce7fe4586 · 2017-12-04T17:43:48.000+02:00
diff --git a/tns-core-modules/application/application.ios.ts b/tns-core-modules/application/application.ios.ts
@@ -17,6 +17,7 @@ export * from "./application-common";
 import { Frame, View, NavigationEntry } from "../ui/frame";
 import { ios } from "../ui/utils";
 import * as utils from "../utils/utils";
+import { profile } from "../profiling";
 
 class Responder extends UIResponder {
     //
@@ -35,6 +36,7 @@ class Window extends UIWindow {
         return window;
     }
 
+    @profile
     public layoutSubviews(): void {
         if (utils.ios.MajorVersion < 9) {
             ios._layoutRootView(this.content, utils.ios.getter(UIScreen, UIScreen.mainScreen).bounds);
@@ -112,6 +114,7 @@ class IOSApplication implements IOSApplicationDefinition {
         }
     }
 
+    @profile
     private didFinishLaunchingWithOptions(notification: NSNotification) {
         this._window = <Window>Window.alloc().initWithFrame(utils.ios.getter(UIScreen, UIScreen.mainScreen).bounds);
         this._window.backgroundColor = utils.ios.getter(UIColor, UIColor.whiteColor);
@@ -146,6 +149,7 @@ class IOSApplication implements IOSApplicationDefinition {
         this._window.makeKeyAndVisible();
     }
 
+    @profile
     private didBecomeActive(notification: NSNotification) {
         let ios = utils.ios.getter(UIApplication, UIApplication.sharedApplication);
         let object = this;
diff --git a/tns-core-modules/ui/frame/frame.ios.ts b/tns-core-modules/ui/frame/frame.ios.ts
@@ -512,6 +512,7 @@ class UINavigationControllerImpl extends UINavigationController {
         }
     }
 
+    @profile
     public viewDidLayoutSubviews(): void {
         let owner = this._owner.get();
         if (owner) {
@@ -551,6 +552,7 @@ class UINavigationControllerImpl extends UINavigationController {
         });
     }
 
+    @profile
     public pushViewControllerAnimated(viewController: UIViewController, animated: boolean): void {
         let navigationTransition = <NavigationTransition>viewController[TRANSITION];
         if (traceEnabled()) {
@@ -568,6 +570,7 @@ class UINavigationControllerImpl extends UINavigationController {
         });
     }
 
+    @profile
     public setViewControllersAnimated(viewControllers: NSArray<any>, animated: boolean): void {
         let viewController = viewControllers.lastObject;
         let navigationTransition = <NavigationTransition>viewController[TRANSITION];
diff --git a/tns-core-modules/ui/page/page.ios.ts b/tns-core-modules/ui/page/page.ios.ts
@@ -72,6 +72,7 @@ class UIViewControllerImpl extends UIViewController {
         return controller;
     }
 
+    @profile
     public viewDidLayoutSubviews() {
         let owner = this._owner.get();
         if (!owner) {
@@ -131,6 +132,7 @@ class UIViewControllerImpl extends UIViewController {
         }
     }
 
+    @profile
     public viewWillAppear(animated: boolean): void {
         super.viewWillAppear(animated);
         this.shown = false;
@@ -189,6 +191,7 @@ class UIViewControllerImpl extends UIViewController {
         page._enableLoadedEvents = false;
     }
 
+    @profile
     public viewDidAppear(animated: boolean): void {
         super.viewDidAppear(animated);
         this.shown = true;
@@ -242,6 +245,7 @@ class UIViewControllerImpl extends UIViewController {
         }
     };
 
+    @profile
     public viewWillDisappear(animated: boolean): void {
         super.viewWillDisappear(animated);
 
@@ -270,6 +274,7 @@ class UIViewControllerImpl extends UIViewController {
         page._viewWillDisappear = true;
     }
 
+    @profile
     public viewDidDisappear(animated: boolean): void {
         super.viewDidDisappear(animated);
 

Original file line number	Diff line number	Diff line change
`@@ -512,6 +512,7 @@ class UINavigationControllerImpl extends UINavigationController {`
`512`	`512`	`}`
`513`	`513`	`}`
`514`	`514`
	`515`	`+ @profile`
`515`	`516`	`public viewDidLayoutSubviews(): void {`
`516`	`517`	`let owner = this._owner.get();`
`517`	`518`	`if (owner) {`
`@@ -551,6 +552,7 @@ class UINavigationControllerImpl extends UINavigationController {`
`551`	`552`	`});`
`552`	`553`	`}`
`553`	`554`
	`555`	`+ @profile`
`554`	`556`	`public pushViewControllerAnimated(viewController: UIViewController, animated: boolean): void {`
`555`	`557`	`let navigationTransition = <NavigationTransition>viewController[TRANSITION];`
`556`	`558`	`if (traceEnabled()) {`
`@@ -568,6 +570,7 @@ class UINavigationControllerImpl extends UINavigationController {`
`568`	`570`	`});`
`569`	`571`	`}`
`570`	`572`
	`573`	`+ @profile`
`571`	`574`	`public setViewControllersAnimated(viewControllers: NSArray<any>, animated: boolean): void {`
`572`	`575`	`let viewController = viewControllers.lastObject;`
`573`	`576`	`let navigationTransition = <NavigationTransition>viewController[TRANSITION];`
Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ class UIViewControllerImpl extends UIViewController {`
`72`	`72`	`return controller;`
`73`	`73`	`}`
`74`	`74`
	`75`	`+ @profile`
`75`	`76`	`public viewDidLayoutSubviews() {`
`76`	`77`	`let owner = this._owner.get();`
`77`	`78`	`if (!owner) {`
`@@ -131,6 +132,7 @@ class UIViewControllerImpl extends UIViewController {`
`131`	`132`	`}`
`132`	`133`	`}`
`133`	`134`
	`135`	`+ @profile`
`134`	`136`	`public viewWillAppear(animated: boolean): void {`
`135`	`137`	`super.viewWillAppear(animated);`
`136`	`138`	`this.shown = false;`
`@@ -189,6 +191,7 @@ class UIViewControllerImpl extends UIViewController {`
`189`	`191`	`page._enableLoadedEvents = false;`
`190`	`192`	`}`
`191`	`193`
	`194`	`+ @profile`
`192`	`195`	`public viewDidAppear(animated: boolean): void {`
`193`	`196`	`super.viewDidAppear(animated);`
`194`	`197`	`this.shown = true;`
`@@ -242,6 +245,7 @@ class UIViewControllerImpl extends UIViewController {`
`242`	`245`	`}`
`243`	`246`	`};`
`244`	`247`
	`248`	`+ @profile`
`245`	`249`	`public viewWillDisappear(animated: boolean): void {`
`246`	`250`	`super.viewWillDisappear(animated);`
`247`	`251`
`@@ -270,6 +274,7 @@ class UIViewControllerImpl extends UIViewController {`
`270`	`274`	`page._viewWillDisappear = true;`
`271`	`275`	`}`
`272`	`276`
	`277`	`+ @profile`
`273`	`278`	`public viewDidDisappear(animated: boolean): void {`
`274`	`279`	`super.viewDidDisappear(animated);`
`275`	`280`