Skip to content

Bug: Primitive type expression between "int" and "byte" buggy #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abego wants to merge 1 commit into from
Closed

Bug: Primitive type expression between "int" and "byte" buggy #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions sources/net.sf.j2s.core/src/net/sf/j2s/core/astvisitors/Java2ScriptVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2583,22 +2583,22 @@ public boolean visit(FieldAccess node) {
// access expressions: qualified names, this expressions, and super
// field access expressions. The following guidelines help with correct
// usage:
// �An expression like "foo.this" can only be represented as a this
// - An expression like "foo.this" can only be represented as a this
// expression (ThisExpression) containing a simple name. "this" is a
// keyword, and therefore invalid as an identifier.
// �An expression like "this.foo" can only be represented as a field
// - An expression like "this.foo" can only be represented as a field
// access expression (FieldAccess) containing a this expression and a
// simple name. Again, this is because "this" is a keyword, and
// therefore invalid as an identifier.
// �An expression with "super" can only be represented as a super field
// - An expression with "super" can only be represented as a super field
// access expression (SuperFieldAccess). "super" is a also keyword, and
// therefore invalid as an identifier.
// �An expression like "foo.bar" can be represented either as a
// - An expression like "foo.bar" can be represented either as a
// qualified name (QualifiedName) or as a field access expression
// (FieldAccess) containing simple names. Either is acceptable, and
// there is no way to choose between them without information about what
// the names resolve to (ASTParser may return either).
// �Other expressions ending in an identifier, such as "foo().bar" can
// - Other expressions ending in an identifier, such as "foo().bar" can
// only be represented as field access expressions (FieldAccess).

IVariableBinding varBinding = node.resolveFieldBinding();
Expand Down Expand Up @@ -3792,7 +3792,7 @@ private boolean addPrimitiveTypedExpression(Expression left, IVariableBinding as
break;
case "int":
if (op != null && (!isDiv && fromIntType) || fromChar || rightName.equals("short")
|| right.equals("byte")) {
|| rightName.equals("byte")) {
left = null;
break;
}
Expand Down