Bug: Primitive type expression between "int" and "byte" buggy #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ======= In `addPrimitiveTypedExpression` operations between primitive types are handled. However there is a typo (using `right` instead of `rightName`) when checking for the "right-part" of an expression with an "int" at the left side. As a result "(int) op (byte)" expressions are not correctly handled. Other Changes ============= - replace non UTF-8 characters with ASCII-chars (in comment)
Collaborator
|
I have incorporated the right/rightName fix into Yadav1. |
Collaborator
|
incorporated into Yadav1 |
BobHanson
added a commit
that referenced
this pull request
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In
addPrimitiveTypedExpressionoperations between primitive typesare handled.
However there is a typo (using
rightinstead ofrightName) whenchecking for the "right-part" of an expression with an "int"
at the left side. As a result "(int) op (byte)" expressions are
not correctly handled.
Other Changes