5.0.1 dual-mode transpiler #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #223 from BobHanson/master
- still an issue. Must explicitly do requestFocus() on MousePressed
Menu issues with touch Frame closing doesn't work with touch JSHTMLHelper doesn't check for node having [0] element PT approx() should leave 0 as 0, not -0
Conflicts: sources/net.sf.j2s.java.core/dist/SwingJS-site.zip
non-SwingJS "Legacy" Jmol was using the java2script 4.2 transpiler which was only operable using Eclipse Juno (4.2, 2013). This new branch integrates that into the SwingJS transpiler, allowing both to be used (and fixed!!) in current Eclipse versions. The difference is detected by using .j2sjmol for legacy and .j2s for SwingJS.
Hooray! Working for Jmol. We can abandon the need to use Eclipse Luna to run the old java2script 4.2 transpiler that was so quirky. Now the transpiler for Jmol creates code directly in the site/ folder, just like the SwingJS transpiler, and changes in "legacy" Jmol can be checked in JavaScript directly using the ?j2sdebugcode directive on the url line.
…ingJS 5.0.1 integrated legacy and swing js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.0.1 dual-mode transpiler uses .j2s (SwingJS, Java 8+) and .j2sjmol (legacy 4.2 unqualified methods version only for legacy Jmol)