fixes add/remove for popup menu

hansonr · hansonr · commit fedc913f5881 · 2018-11-21T12:34:45.000-06:00
diff --git a/sources/net.sf.j2s.core/dist/swingjs/SwingJS-site.zip b/sources/net.sf.j2s.core/dist/swingjs/SwingJS-site.zip
diff --git a/sources/net.sf.j2s.core/dist/swingjs/timestamp b/sources/net.sf.j2s.core/dist/swingjs/timestamp
@@ -1 +1 @@
-20181120230421 
+20181121123334 
diff --git a/sources/net.sf.j2s.core/dist/swingjs/ver/3.2.4/SwingJS-site.zip b/sources/net.sf.j2s.core/dist/swingjs/ver/3.2.4/SwingJS-site.zip
diff --git a/sources/net.sf.j2s.core/dist/swingjs/ver/3.2.4/timestamp b/sources/net.sf.j2s.core/dist/swingjs/ver/3.2.4/timestamp
@@ -1 +1 @@
-20181120230421 
+20181121123334 
diff --git a/sources/net.sf.j2s.java.core/dist/SwingJS-site.zip b/sources/net.sf.j2s.java.core/dist/SwingJS-site.zip
diff --git a/sources/net.sf.j2s.java.core/src/swingjs/jquery/j2sMenu.js b/sources/net.sf.j2s.java.core/src/swingjs/jquery/j2sMenu.js
@@ -125,7 +125,7 @@ Swing.__getMenuStyle = function(applet) { return '\
 	.swingjsPopupMenu .ui-icon{display:block;text-indent:-99999px;overflow:hidden;background-repeat:no-repeat;position:absolute;top:.2em;left:.2em}\
 	.swingjsPopupMenu .ui-menu-icon{position:static;float:right}\
 	.swingjsPopupMenu .ui-icon-carat-1-e{min-width:10ex;text-align:right;background-image:none;background-position:0 0}\
-	.swingjsPopupMenu .ui-icon-carat-1-e:after{content:"\\0023F5"}\
+	.swingjsPopupMenu .ui-icon-carat-1-e:after{content:"\\0025B6"}\
 	.swingjsPopupMenu .ui-state-default{border:1px solid #c5dbec;background:#dfeffc;color:#2e6e9e}\
 	.swingjsPopupMenu .ui-state-default a{color:#2e6e9e;text-decoration:none}\
 	.swingjsPopupMenu .ui-state-hover,.swingjsPopupMenu .ui-state-focus{border:1px solid #79b7e7;background:#d0e5f5;color:#1d5987}\
diff --git a/sources/net.sf.j2s.java.core/src/swingjs/plaf/JSMenuUI.java b/sources/net.sf.j2s.java.core/src/swingjs/plaf/JSMenuUI.java
@@ -8,8 +8,8 @@
 import javax.swing.JComponent;
 import javax.swing.JMenu;
 import swingjs.api.js.DOMNode;
-public class JSMenuUI extends JSMenuItemUI implements ContainerListener {
-
+public class JSMenuUI extends JSMenuItemUI {
+	
 	private JMenu jm;
 
 	public JSMenuUI() {
@@ -76,8 +76,6 @@ public boolean handleJSEvent(Object target, int eventType, Object jQueryEvent) {
 	public void installUI(JComponent jc) {
 		jm = (JMenu) jc;
 		super.installUI(jc);
-		// handle add/remove
-		jm.getPopupMenu().addContainerListener(this);
 	}
 
 	@Override
@@ -91,22 +89,4 @@ public Dimension getMaximumSize() {
 		return getPreferredSize();
 	}
 
-	@Override
-	public void componentAdded(ContainerEvent e) {
-		JSPopupMenuUI popupui = (JSPopupMenuUI) jm.getPopupMenu().getUI();
-		// OK, the idea here is that we detach all child nodes
-		// and then reattach them. 
-		DOMNode.detachAll(popupui.outerNode);
-		popupui.setTainted();
-		popupui.setHTMLElement();
-	}
-
-	@Override
-	public void componentRemoved(ContainerEvent e) {
-		JSPopupMenuUI popupui = (JSPopupMenuUI) jm.getPopupMenu().getUI();
-		DOMNode.detachAll(popupui.outerNode);
-		popupui.setTainted();
-		popupui.setHTMLElement();
-	}
-
 }
diff --git a/sources/net.sf.j2s.java.core/src/swingjs/plaf/JSPopupMenuUI.java b/sources/net.sf.j2s.java.core/src/swingjs/plaf/JSPopupMenuUI.java
@@ -4,6 +4,8 @@
 import java.awt.Dimension;
 import java.awt.event.ComponentEvent;
 import java.awt.event.ComponentListener;
+import java.awt.event.ContainerEvent;
+import java.awt.event.ContainerListener;
 
 import javax.swing.JComponent;
 import javax.swing.JPopupMenu;
@@ -13,17 +15,35 @@
 import swingjs.jquery.JQueryUI;
 import swingjs.api.js.DOMNode;
 
-public class JSPopupMenuUI extends JSPanelUI {
+public class JSPopupMenuUI extends JSPanelUI implements ContainerListener {
+
 	
 	static {
 		Object jqueryui = JQueryUI.class; // loads jQuery.ui
 	}
 
 	// a frameless independent window
 	
-	static JSSwingMenu j2sSwingMenu;
+	private static JSSwingMenu j2sSwingMenu;
 	
-	int timer;
+
+	@Override
+	public void componentAdded(ContainerEvent e) {
+		// OK, the idea here is that we detach all child nodes
+		// and then reattach them. 
+		DOMNode.detachAll(outerNode);
+		setTainted();
+		setHTMLElement();
+	}
+
+	@Override
+	public void componentRemoved(ContainerEvent e) {
+		DOMNode.detachAll(outerNode);
+		setTainted();
+		setHTMLElement();
+	}
+
+	/*private*/ int timer;
 
 	public JSPopupMenuUI() {
 		
@@ -51,6 +71,7 @@ public DOMNode updateDOMNode() {
 
 	@Override
 	public void installUI(JComponent jc) {
+		((JPopupMenu) jc).addContainerListener(this);
       LookAndFeel.installColorsAndFont(jc,
         "PopupMenu.background",
         "PopupMenu.foreground",
@@ -59,6 +80,7 @@ public void installUI(JComponent jc) {
 
 	@Override
 	public void uninstallUI(JComponent jc) {
+		((JPopupMenu) jc).removeContainerListener(this);
 		// TODO Auto-generated method stub
 		
 	}
@@ -122,14 +144,16 @@ void stopTimer() {
 	void hideMenu() {
 		System.out.println("hideMenu");
 		// not private -- hideMenu$
-		j2sSwingMenu.hideMenu(menu);	
+		if (menu != null)
+			j2sSwingMenu.hideMenu(menu);	
 	}
 	
 	@Override
 	public void dispose() {
     DOMNode.dispose(domNode);
     DOMNode.dispose(outerNode);
-    j2sSwingMenu.disposeMenu(menu);
+    if (menu != null)
+    	j2sSwingMenu.disposeMenu(menu);
 	}
 
 	@Override
diff --git a/sources/net.sf.j2s.java.core/src/test/JalviewJSTest.java b/sources/net.sf.j2s.java.core/src/test/JalviewJSTest.java
@@ -11,6 +11,8 @@
 import java.awt.event.ActionListener;
 import java.awt.event.ItemEvent;
 import java.awt.event.ItemListener;
+import java.awt.event.MouseEvent;
+import java.awt.event.MouseListener;
 
 import javax.swing.ImageIcon;
 import javax.swing.JButton;
@@ -22,6 +24,7 @@
 import javax.swing.JMenuBar;
 import javax.swing.JMenuItem;
 import javax.swing.JPanel;
+import javax.swing.JPopupMenu;
 import javax.swing.JRadioButton;
 import javax.swing.JRadioButtonMenuItem;
 import javax.swing.SwingConstants;
@@ -59,6 +62,50 @@ void doTest()
     main.getJMenuBar().add(menu);
     main.pack();
     main.setVisible(true);
+    
+    JPopupMenu pmenu = new JPopupMenu();
+    pmenu.add(new JMenuItem("testing1"));
+    pmenu.add(new JMenuItem("testing2"));
+    pmenu.add(new JMenuItem("testing3"));
+
+    main.addMouseListener(new MouseListener() {
+
+		@Override
+		public void mouseClicked(MouseEvent e) {
+			System.out.println(pmenu.getComponents().length);
+			pmenu.remove(pmenu.getComponents().length - 1);
+			System.out.println(pmenu.getComponents().length);
+			pmenu.show(main,  100,  100);
+			System.out.println(pmenu.getComponents().length);
+			// TODO Auto-generated method stub
+			
+		}
+
+		@Override
+		public void mousePressed(MouseEvent e) {
+			// TODO Auto-generated method stub
+			
+		}
+
+		@Override
+		public void mouseReleased(MouseEvent e) {
+			// TODO Auto-generated method stub
+			
+		}
+
+		@Override
+		public void mouseEntered(MouseEvent e) {
+			// TODO Auto-generated method stub
+			
+		}
+
+		@Override
+		public void mouseExited(MouseEvent e) {
+			// TODO Auto-generated method stub
+			
+		}
+    	
+    });
   }
 
   /**
