Bug: "Comparing identical expressions" warnings in DoubleTest/FloatTest

abego · abego · commit d18433981760 · 2017-06-21T13:57:26.000+02:00
This is related to tests like this: assertTrue("-0d should be == 0d", 0d == -0d); I.e. the warning can be ignored, as we are explicitly checking for identical expressions. Fix: add '@SuppressWarnings("all") // "Comparing identical expressions" ...' to the methods raising the warning.
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/DoubleTest.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/DoubleTest.java
@@ -392,6 +392,7 @@ public void test_doubleValue() {
 	/**
 	 * @tests java.lang.Double#equals(java.lang.Object)
 	 */
+	@SuppressWarnings("all") // "Comparing identical expressions" 0d == -0d
 	public void test_equalsLjava_lang_Object() {
 		// Test for method boolean java.lang.Double.equals(java.lang.Object)
 
diff --git a/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/FloatTest.java b/tests/net.sf.j2s.test.junit/src/net/sf/j2s/test/junit/FloatTest.java
@@ -202,6 +202,7 @@ public void test_doubleValue() {
 	/**
 	 * @tests java.lang.Float#equals(java.lang.Object)
 	 */
+	@SuppressWarnings("all") // "Comparing identical expressions" 0f == -0f
 	public void test_equalsLjava_lang_Object() {
 		// Test for method boolean java.lang.Float.equals(java.lang.Object)
 
@@ -552,6 +553,7 @@ public void test_toStringF() {
 	/**
 	 * @tests java.lang.Float#valueOf(java.lang.String)
 	 */
+	@SuppressWarnings("all") // "Comparing identical expressions" 0.0f == -0.0f
 	public void test_valueOfLjava_lang_String() {
 		// Test for method java.lang.Float
 		// java.lang.Float.valueOf(java.lang.String)
