Matcher.getGroup(int) was passing undefined; should be null

BobHanson · BobHanson · commit b83b53d2b119 · 2020-06-30T07:24:56.000-05:00
diff --git a/sources/net.sf.j2s.java.core/src/java/util/regex/Matcher.java b/sources/net.sf.j2s.java.core/src/java/util/regex/Matcher.java
@@ -953,7 +953,9 @@ public String group(int group) {
 			throw new IllegalStateException("No match found");
 		if (group < 0 || group > groupCount())
 			throw new IndexOutOfBoundsException("No group " + group);
-		return results[group];
+		// this array is coming from JavaScript RegExp; some values may be "undefined"
+		// so we force them to be null. 
+		return results[group] == null ? null : results[group];
 //        if ((groups[group*2] == -1) || (groups[group*2+1] == -1))
 //            return null;
 //        return getSubSequence(groups[group * 2], groups[group * 2 + 1]).toString();
