the following fix introduces an error... reverting fix until a solution is found

sebastigurin · sebastigurin · commit a18644570c5a · 2010-08-01T01:26:28.000Z
diff --git a/src/net/sf/j2s/core/astvisitors/DependencyASTVisitor.java b/src/net/sf/j2s/core/astvisitors/DependencyASTVisitor.java
@@ -956,10 +956,14 @@ public boolean visit(MethodInvocation node) {
 					optionals.add(qn);
 				}
 			}
+			
+			//the ofllowing fix introduces an error... reverting fix until a solution is found
 			//sgurin: fix for bug http://sourceforge.net/tracker/?func=detail&aid=3037341&group_id=155436&atid=795800
-			String methodOwnerClassName = resolveMethodBinding.getDeclaringClass().getQualifiedName();
-			if(methodOwnerClassName!=null && !methodOwnerClassName.equals("")) 
-				requires.add(methodOwnerClassName);
+			//in a static method call, if the mehthod's type is not this class, we require it.
+//			String methodOwnerClassName = resolveMethodBinding.getDeclaringClass().getQualifiedName();
+//			if(methodOwnerClassName!=null && !methodOwnerClassName.equals(Bindings.getBindingOfParentType(node).getQualifiedName())) {
+//				requires.add(methodOwnerClassName);
+//			}
 		}
 		return super.visit(node);
 	}

Original file line number	Diff line number	Diff line change
`@@ -956,10 +956,14 @@ public boolean visit(MethodInvocation node) {`
`956`	`956`	`optionals.add(qn);`
`957`	`957`	`}`
`958`	`958`	`}`
	`959`	`+`
	`960`	`+ //the ofllowing fix introduces an error... reverting fix until a solution is found`
`959`	`961`	`//sgurin: fix for bug http://sourceforge.net/tracker/?func=detail&aid=3037341&group_id=155436&atid=795800`
`960`		`- String methodOwnerClassName = resolveMethodBinding.getDeclaringClass().getQualifiedName();`
`961`		`- if(methodOwnerClassName!=null && !methodOwnerClassName.equals(""))`
`962`		`- requires.add(methodOwnerClassName);`
	`962`	`+ //in a static method call, if the mehthod's type is not this class, we require it.`
	`963`	`+// String methodOwnerClassName = resolveMethodBinding.getDeclaringClass().getQualifiedName();`
	`964`	`+// if(methodOwnerClassName!=null && !methodOwnerClassName.equals(Bindings.getBindingOfParentType(node).getQualifiedName())) {`
	`965`	`+// requires.add(methodOwnerClassName);`
	`966`	`+// }`
`963`	`967`	`}`
`964`	`968`	`return super.visit(node);`
`965`	`969`	`}`